debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-12-22 17:34:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

cli: bail out and propagate tagging errors in notmuch tag

Browse source 
Checking and propagating tag_op_list_apply() errors is especially
important with batch tagging, as the processing of the batch input
would not stop otherwise. Additionally this sets the exit code, which
is useful in scripts.

Amended by: David Bremner
This commit is contained in:
Jani Nikula 2013-01-08 23:41:54 +02:00 committed by David Bremner
parent ff3cc5534a
commit 4e9fe60422
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
notmuch-tag.c
View file

@ -97,6 +97,7 @@ tag_query (void *ctx, notmuch_database_t *notmuch, const char *query_string,
notmuch_query_t *query;
notmuch_messages_t *messages;
notmuch_message_t *message;
int ret = 0;
/* Optimize the query so it excludes messages that already have
* the specified set of tags. */
@ -119,13 +120,15 @@ tag_query (void *ctx, notmuch_database_t *notmuch, const char *query_string,
notmuch_messages_valid (messages) && ! interrupted;
notmuch_messages_move_to_next (messages)) {
message = notmuch_messages_get (messages);
tag_op_list_apply (message, tag_ops, flags | TAG_FLAG_PRE_OPTIMIZED);
ret = tag_op_list_apply (message, tag_ops, flags | TAG_FLAG_PRE_OPTIMIZED);
notmuch_message_destroy (message);
if (ret != NOTMUCH_STATUS_SUCCESS)
break;
}
notmuch_query_destroy (query);
return interrupted;
return ret || interrupted;
}
static int