debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2025-01-03 15:21:41 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

lib/message.cc: stale pointer bug (v3)

Browse source 
Xapian::TermIterator::operator* returns std::string which is destroyed
as soon as (*i).c_str() finishes. The remembered pointer 'term' then
references invalid memory.

Signed-off-by: Vladimir Marek <vlmarek@volny.cz>
This commit is contained in:
Vladimir Marek 2013-05-02 16:31:42 +02:00 committed by David Bremner
parent 8bee3c417c
commit 51b073c6f2
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/message.cc
View file

@ -266,18 +266,18 @@ _notmuch_message_get_term (notmuch_message_t *message,
const char *prefix) const char *prefix)
{ {
int prefix_len = strlen (prefix); int prefix_len = strlen (prefix);
const char *term = NULL;
char *value; char *value;
i.skip_to (prefix); i.skip_to (prefix);
if (i != end) if (i == end)
term = (*i).c_str ();
if (!term || strncmp (term, prefix, prefix_len))
return NULL; return NULL;
value = talloc_strdup (message, term + prefix_len); std::string term = *i;
if (strncmp (term.c_str(), prefix, prefix_len))
return NULL;
value = talloc_strdup (message, term.c_str() + prefix_len);
#if DEBUG_DATABASE_SANITY #if DEBUG_DATABASE_SANITY
i++; i++;