From 51cd69feb1d131db7a468e33e0fa2e043caad41e Mon Sep 17 00:00:00 2001 From: Carl Worth Date: Fri, 17 Sep 2010 15:30:17 -0700 Subject: [PATCH] test: Remove basic testing of broken, fixed, and skipped tests. These were interfering with the aggregate statistics reported at the end of the test-suite run. (Always reporting 1 broken, 1 fixed, and 1 skipped). The correct way to test the test-suite itself would be to run the test suite externally for these cases, capture the expected result, and then report that as a PASS test. But, really, there's almost no value in these tests anyway. It's almost to the level of testing that 'if false; exit 1; fi' returns 1. That is, there are so many ways that the test suite could be broken internally, that these minor tests don't really help. --- test/t0000-basic.sh | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/test/t0000-basic.sh b/test/t0000-basic.sh index 2cc4ef75..eb109533 100755 --- a/test/t0000-basic.sh +++ b/test/t0000-basic.sh @@ -21,27 +21,12 @@ fi test_expect_success 'success is reported like this' ' : ' -test_expect_failure 'pretend we have a known breakage' ' - false -' -test_expect_failure 'pretend we have fixed a known breakage' ' - : -' test_set_prereq HAVEIT haveit=no test_expect_success HAVEIT 'test runs if prerequisite is satisfied' ' test_have_prereq HAVEIT && haveit=yes ' -donthaveit=yes -test_expect_success DONTHAVEIT 'unmet prerequisite causes test to be skipped' ' - donthaveit=no -' -if test $haveit$donthaveit != yesyes -then - say "bug in test framework: prerequisite tags do not work reliably" - exit 1 -fi clean=no test_expect_success 'tests clean up after themselves' '