mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-11-22 02:48:08 +01:00
notmuch-dump: deprecate use of output file argument.
We print an intentionally non-specific message on stderr, since it isn't clear if there will be some global output file argument to replace. We update the test suite atomically, since it relies on having the same text in two files.
This commit is contained in:
parent
09beff1def
commit
53b397acfc
2 changed files with 5 additions and 0 deletions
|
@ -42,6 +42,7 @@ notmuch_dump_command (unused (void *ctx), int argc, char *argv[])
|
|||
return 1;
|
||||
|
||||
if (argc && strcmp (argv[0], "--") != 0) {
|
||||
fprintf (stderr, "Warning: the output file argument of dump is deprecated.\n");
|
||||
output = fopen (argv[0], "w");
|
||||
if (output == NULL) {
|
||||
fprintf (stderr, "Error opening %s for writing: %s\n",
|
||||
|
|
|
@ -12,6 +12,10 @@ test_begin_subtest "dump outfile"
|
|||
notmuch dump dump-outfile.actual
|
||||
test_expect_equal_file dump.expected dump-outfile.actual
|
||||
|
||||
test_begin_subtest "dump outfile # deprecated"
|
||||
test_expect_equal "Warning: the output file argument of dump is deprecated."\
|
||||
"$(notmuch dump /dev/null 2>&1)"
|
||||
|
||||
test_begin_subtest "dump outfile --"
|
||||
notmuch dump dump-1-arg-dash.actual --
|
||||
test_expect_equal_file dump.expected dump-1-arg-dash.actual
|
||||
|
|
Loading…
Reference in a new issue