From 54190d091cbceb345c489bd3f20fdca7e4b9a111 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 31 Jul 2022 20:32:11 +0300 Subject: [PATCH] notmuch.c: add missing trailing newlines in two error messages Removed duplicate error check (and the message) in 3rd case where the same error message (w/o trailing newline) was present. In case of test/T040-setup.sh, command substitution deletes trailing newlines, so related test there cannot be changed (and therefore could not notice this user experience flaw). --- notmuch.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/notmuch.c b/notmuch.c index c75b0188..37286b8f 100644 --- a/notmuch.c +++ b/notmuch.c @@ -531,7 +531,7 @@ main (int argc, char *argv[]) } if (status == NOTMUCH_STATUS_NO_CONFIG) - fputs ("Try running 'notmuch setup' to create a configuration.", stderr); + fputs ("Try running 'notmuch setup' to create a configuration.\n", stderr); return EXIT_FAILURE; } @@ -563,15 +563,10 @@ main (int argc, char *argv[]) NULL, ¬much, &status_string); - - if (status == NOTMUCH_STATUS_NO_CONFIG && ! (command->mode & NOTMUCH_COMMAND_CONFIG_CREATE)) { - fputs ("Try running 'notmuch setup' to create a configuration.", stderr); - goto DONE; - } switch (status) { case NOTMUCH_STATUS_NO_CONFIG: if (! (command->mode & NOTMUCH_COMMAND_CONFIG_CREATE)) { - fputs ("Try running 'notmuch setup' to create a configuration.", stderr); + fputs ("Try running 'notmuch setup' to create a configuration.\n", stderr); goto DONE; } break;