From 557965b8fae3d7923cee0fb8d9b298173e73a264 Mon Sep 17 00:00:00 2001 From: Michal Sojka Date: Tue, 29 Dec 2015 22:55:40 +0100 Subject: [PATCH] doc/reply: Clarify how reply-to header is handled Current documentation and comments in the code do not correspond to the actual code and tests in the test suite ("Un-munging Reply-To" in T230-reply-to-sender.sh). Fix it. --- doc/man1/notmuch-reply.rst | 6 ++++-- notmuch-reply.c | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/man1/notmuch-reply.rst b/doc/man1/notmuch-reply.rst index cfbd4ea8..d73f8f1c 100644 --- a/doc/man1/notmuch-reply.rst +++ b/doc/man1/notmuch-reply.rst @@ -13,8 +13,10 @@ DESCRIPTION Constructs a reply template for a set of messages. To make replying to email easier, **notmuch reply** takes an existing -set of messages and constructs a suitable mail template. The Reply-to: -header (if any, otherwise From:) is used for the To: address. Unless +set of messages and constructs a suitable mail template. Its To: +address is set according to the original email in this way: if the +Reply-to: header is present and different from any To:/Cc: address it +is used, otherwise From: header is used. Unless ``--reply-to=sender`` is specified, values from the To: and Cc: headers are copied, but not including any of the current user's email addresses (as configured in primary\_mail or other\_email in the .notmuch-config diff --git a/notmuch-reply.c b/notmuch-reply.c index 6df54fc9..3c6d685c 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -332,7 +332,7 @@ add_recipients_from_message (GMimeMessage *reply, * field and use the From header. This ensures the original sender * will get the reply even if not subscribed to the list. Note * that the address in the Reply-To header will always appear in - * the reply. + * the reply if reply_all is true. */ if (reply_to_header_is_redundant (message)) { reply_to_map[0].header = "from";