debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-12-22 17:34:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

add_message: Fix memory leak of thread_ids GPtrArray.

Browse source 
We were properly feeing this memory when the thread-ids list was not
empty, but leaking it when it was.

Thanks, of course, to valgrind along with the G_SLICE=always-malloc
environment variable which makes leak checking with glib almost
bearable.
This commit is contained in:
Carl Worth 2009-10-20 13:05:45 -07:00
parent e6236b88fd
commit 5a84df0f15
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
database.cc
View file

@ -577,7 +577,6 @@ notmuch_database_add_message (notmuch_database_t *notmuch,
free (id); free (id);
} }
g_ptr_array_free (thread_ids, TRUE);
doc.add_value (NOTMUCH_VALUE_THREAD, thread_id->str); doc.add_value (NOTMUCH_VALUE_THREAD, thread_id->str);
g_string_free (thread_id, TRUE); g_string_free (thread_id, TRUE);
} else if (message_id) { } else if (message_id) {
@ -589,6 +588,8 @@ notmuch_database_add_message (notmuch_database_t *notmuch,
doc.add_value (NOTMUCH_VALUE_THREAD, thread_id.str); doc.add_value (NOTMUCH_VALUE_THREAD, thread_id.str);
} }
g_ptr_array_free (thread_ids, TRUE);
free (message_id); free (message_id);
date = notmuch_message_get_header (message, "date"); date = notmuch_message_get_header (message, "date");