debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-28 21:54:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: jump: sort-order bugfix

Browse source 
default-value needs its argument to be quoted.

Slightly strangely default-value of 't or nil is 't or nil
respectively so the code

(default-value notmuch-search-oldest-first)

just gives the current value of notmuch-search-oldest-first rather
than intended default-value of this variable.

The symptom is that if you are in a search buffer and use notmuch jump
to run a saved search which does not have an explicitly set sort order
then the sort order of the saved-search is inherited from the current
search buffer rather than being the default search order.

Thanks to Jani for finding the bug.
This commit is contained in:
Mark Walters 2014-09-02 19:56:04 +01:00 committed by David Bremner
parent 3d39d346d7
commit 5c4f6ed99b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
emacs/notmuch-jump.el
View file

@ -51,7 +51,7 @@ fast way to jump to a saved search from anywhere in Notmuch."
(case (plist-get saved-search :sort-order) (case (plist-get saved-search :sort-order)
(newest-first nil) (newest-first nil)
(oldest-first t) (oldest-first t)
(otherwise (default-value notmuch-search-oldest-first))))) (otherwise (default-value 'notmuch-search-oldest-first)))))
(push (list key name (push (list key name
`(lambda () (notmuch-search ',query ',oldest-first))) `(lambda () (notmuch-search ',query ',oldest-first)))
action-map))))) action-map)))))