From 5cc106b0e3e53f56b189ef067753ea5f29cb4243 Mon Sep 17 00:00:00 2001 From: Protesilaos Stavrou Date: Fri, 21 May 2021 19:55:31 +0300 Subject: [PATCH] emacs: use new face for notmuch-jump and related The minibuffer-prompt face that was used before made it impossible to differentiate between two distinct UI elements: (i) the prompt's text which itself cannot be acted upon, (ii) the actionable keys used to jump to searches/tags. The use of a named face, notmuch-jump-key, makes it possible for users or theme developers to apply properties that are specific to each of those two cases. In the interest of backward compatibility, the new face inherits from minibuffer-prompt. --- NEWS | 4 ++++ emacs/notmuch-jump.el | 9 +++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 4f247f00..3e776009 100644 --- a/NEWS +++ b/NEWS @@ -68,6 +68,10 @@ Emacs Restore the dynamically bound variables `tag-changes` and `query` in in `notmuch-before-tag-hook` and `notmuch-after-tag-hook`. +Add `notmuch-jump-key` face to fontify keys in `notmuch-jump` and +related functions. To ensure backward compatibility, the new face +inherits from `minibuffer-prompt`. + Notmuch 0.32 (2021-05-02) ========================= diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el index 6fab5a79..e228c8a2 100644 --- a/emacs/notmuch-jump.el +++ b/emacs/notmuch-jump.el @@ -62,6 +62,11 @@ fast way to jump to a saved search from anywhere in Notmuch." (error "To use notmuch-jump, %s" "please customize shortcut keys in notmuch-saved-searches.")))) +(defface notmuch-jump-key + '((t :inherit minibuffer-prompt)) + "Default face used for keys in `notmuch-jump' and related." + :group 'notmuch-faces) + (defvar notmuch-jump--action nil) ;;;###autoload @@ -88,7 +93,7 @@ not appear in the pop-up buffer." (buffer-string))) (full-prompt (concat table "\n\n" - (propertize prompt 'face 'minibuffer-prompt))) + (propertize prompt 'face 'notmuch-jump-key))) ;; By default, the minibuffer applies the minibuffer face to ;; the entire prompt. However, we want to clearly ;; distinguish bindings (which we put in the prompt face @@ -123,7 +128,7 @@ buffer." ;; Format each action (mapcar (pcase-lambda (`(,key ,desc)) (setq key (format-kbd-macro key)) - (concat (propertize key 'face 'minibuffer-prompt) + (concat (propertize key 'face 'notmuch-jump-key) (make-string (- key-width (length key)) ? ) " " desc)) action-map)))