debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-25 04:18:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Avoid bogus internal error reporting duplicate In-Reply-To IDs.

Browse source 
This error was tirggered with a debugging build via:

	make CXXFLAGS="-DDEBUG"

and reported by David Bremner. The actual error is that I'm an
idiot that doesn't know how to use strcmp's return value. Of
course, the strcmp interface scores a negative 7 on Rusty Russell
ranking of bad interfaces:

http://ozlabs.org/~rusty/index.cgi/tech/2008-04-01.html
This commit is contained in:
Carl Worth 2009-11-28 10:01:22 -08:00
parent 0a7bd1c728
commit 64c8d6227a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/message.cc
View file

@ -318,7 +318,7 @@ _notmuch_message_get_in_reply_to (notmuch_message_t *message)
in_reply_to = *i;
if (i != message->doc.termlist_end () &&
strncmp ((*i).c_str (), prefix, prefix_len))
strncmp ((*i).c_str (), prefix, prefix_len) == 0)
{
INTERNAL_ERROR ("Message %s has duplicate In-Reply-To IDs: %s and %s\n",
notmuch_message_get_message_id (message),