mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-12-23 01:44:52 +01:00
test: only exclude "deleted" messages from search if explicitly configured
Currently, the 'search.exclude_tags' option is automatically set to "deleted;spam;" if it's missing from the config file. This violates the Principle of Least Surprise, so update the tests to *only* expect the exclusion of messages which are tagged "deleted" if the 'search.exclude_tags' option is explicitly set *and* contains that tag.
This commit is contained in:
parent
649a9f5f3a
commit
6795c62a50
1 changed files with 8 additions and 0 deletions
|
@ -130,6 +130,7 @@ output=$(notmuch search "bödý" | notmuch_search_sanitize)
|
||||||
test_expect_equal "$output" "thread:XXX 2000-01-01 [1/1] Notmuch Test Suite; utf8-message-body-subject (inbox unread)"
|
test_expect_equal "$output" "thread:XXX 2000-01-01 [1/1] Notmuch Test Suite; utf8-message-body-subject (inbox unread)"
|
||||||
|
|
||||||
test_begin_subtest "Exclude \"deleted\" messages from search"
|
test_begin_subtest "Exclude \"deleted\" messages from search"
|
||||||
|
notmuch config set search.exclude_tags = deleted
|
||||||
generate_message '[subject]="Not deleted"'
|
generate_message '[subject]="Not deleted"'
|
||||||
generate_message '[subject]="Deleted"'
|
generate_message '[subject]="Deleted"'
|
||||||
notmuch new > /dev/null
|
notmuch new > /dev/null
|
||||||
|
@ -147,4 +148,11 @@ output=$(notmuch search subject:deleted | notmuch_search_sanitize)
|
||||||
test_expect_equal "$output" "thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Not deleted (inbox unread)
|
test_expect_equal "$output" "thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Not deleted (inbox unread)
|
||||||
thread:XXX 2001-01-05 [1/2] Notmuch Test Suite; Not deleted reply (deleted inbox unread)"
|
thread:XXX 2001-01-05 [1/2] Notmuch Test Suite; Not deleted reply (deleted inbox unread)"
|
||||||
|
|
||||||
|
test_begin_subtest "Don't exclude \"deleted\" messages from search if not configured"
|
||||||
|
test_subtest_known_broken
|
||||||
|
notmuch config set search.exclude_tags
|
||||||
|
output=$(notmuch search subject:deleted | notmuch_search_sanitize)
|
||||||
|
test_expect_equal "$output" "thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Not deleted (inbox unread)
|
||||||
|
thread:XXX 2001-01-05 [2/2] Notmuch Test Suite; Deleted (deleted inbox unread)"
|
||||||
|
|
||||||
test_done
|
test_done
|
||||||
|
|
Loading…
Reference in a new issue