debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-22 02:48:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: with-current-notmuch-show-message' should not leak coding-system-for-read'

Browse source 
`with-current-notmuch-show-message' applies a `no-conversion' coding
system when reading a raw message from notmuch. That coding system
should _not_ be applied when the body of the macro is evaluated, as it
can cause file operations used during that evaluation to incorrectly
apply the `no-conversion' coding system.

This was discovered when a user's .signature file contained non-ASCII
characters. When a message is forwarded, the `no-conversion' coding
system was applied to the reading of the .signature file, resulting in
raw rather than UTF-8 interpretation of the data.
This commit is contained in:
David Edmondson 2014-11-18 07:03:17 +00:00 committed by David Bremner
parent 32855b91d9
commit 7585e8c906
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
emacs/notmuch-show.el
View file

@ -241,9 +241,9 @@ every user interaction with notmuch."
(let ((buf (generate-new-buffer (concat "*notmuch-msg-" id "*")))) (let ((buf (generate-new-buffer (concat "*notmuch-msg-" id "*"))))
(with-current-buffer buf (with-current-buffer buf
(let ((coding-system-for-read 'no-conversion)) (let ((coding-system-for-read 'no-conversion))
(call-process notmuch-command nil t nil "show" "--format=raw" id) (call-process notmuch-command nil t nil "show" "--format=raw" id))
,@body) ,@body)
(kill-buffer buf)))))) (kill-buffer buf)))))
(defun notmuch-show-turn-on-visual-line-mode () (defun notmuch-show-turn-on-visual-line-mode ()
"Enable Visual Line mode." "Enable Visual Line mode."