From 776a2982ae5f3fd8accfae173a32038a01b79a57 Mon Sep 17 00:00:00 2001 From: Daniel Kahn Gillmor Date: Tue, 5 Dec 2017 21:33:22 -0500 Subject: [PATCH] test: searching by absolute date is broken without Xapian FieldProcessor Previously, the test suite had simply silently skipped the absolute date test if we're using an archaic version of Xapian. For correctness, we should instead mark the test as broken. This also changes from string to numeric comparison when checking NOMTUCH_HAVE_XAPIAN_FIELD_PROCESSOR for consistency with other tests. --- test/T500-search-date.sh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/T500-search-date.sh b/test/T500-search-date.sh index 5c5b99a0..f84b0962 100755 --- a/test/T500-search-date.sh +++ b/test/T500-search-date.sh @@ -12,11 +12,12 @@ test_begin_subtest "Absolute date range with 'same' operator" output=$(notmuch search date:2010-12-16..! | notmuch_search_sanitize) test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger; Essai accentué (inbox unread)" -if [ "${NOTMUCH_HAVE_XAPIAN_FIELD_PROCESSOR}" = "1" ]; then - test_begin_subtest "Absolute date field" - output=$(notmuch search date:2010-12-16 | notmuch_search_sanitize) - test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger; Essai accentué (inbox unread)" +test_begin_subtest "Absolute date field" +output=$(notmuch search date:2010-12-16 | notmuch_search_sanitize) +if [ $NOTMUCH_HAVE_XAPIAN_FIELD_PROCESSOR -ne 1 ]; then + test_subtest_known_broken fi +test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger; Essai accentué (inbox unread)" test_begin_subtest "Absolute time range with TZ" notmuch search date:18-Nov-2009_02:19:26-0800..2009-11-18_04:49:52-06:00 | notmuch_search_sanitize > OUTPUT