From 7a6394257722c81dd47adefb172c8df2ac898973 Mon Sep 17 00:00:00 2001 From: Carl Worth Date: Mon, 30 Nov 2009 23:14:11 -0800 Subject: [PATCH] notmuch.el: Use let to avoid assigning to a free variable. The dynamic scoping of emacs lisp is such that we never want to assign to any variable unless it's something we've defined with `defvar' or else something we're using locally via `let'. --- notmuch.el | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/notmuch.el b/notmuch.el index 94a63844..e605d9d2 100644 --- a/notmuch.el +++ b/notmuch.el @@ -1081,12 +1081,11 @@ Complete list of currently available key bindings: (if (not notmuch-tag-face-alist) (add-to-list 'notmuch-search-font-lock-keywords (list "(\\([^)]*\\))$" '(1 'notmuch-tag-face))) - (progn - (setq notmuch-search-tags (mapcar 'car notmuch-tag-face-alist)) - (loop for notmuch-search-tag in notmuch-search-tags - do (add-to-list 'notmuch-search-font-lock-keywords (list - (concat "([^)]*\\(" notmuch-search-tag "\\)[^)]*)$") - `(1 ,(cdr (assoc notmuch-search-tag notmuch-tag-face-alist)))))))) + (let ((notmuch-search-tags (mapcar 'car notmuch-tag-face-alist))) + (loop for notmuch-search-tag in notmuch-search-tags + do (add-to-list 'notmuch-search-font-lock-keywords (list + (concat "([^)]*\\(" notmuch-search-tag "\\)[^)]*)$") + `(1 ,(cdr (assoc notmuch-search-tag notmuch-tag-face-alist)))))))) (set (make-local-variable 'font-lock-defaults) '(notmuch-search-font-lock-keywords t)))