emacs: Fix mail composition under Emacs 23

Commit 570c0aeb40 reworked
notmuch-mua-mail function in a way that worked only under Emacs 24.
The reason was that message-setup-1 took one argument less in Emacs
23.

We fix this by only supplying the return-action argument when it is
actually set by the caller.
This commit is contained in:
Michal Sojka 2016-01-02 17:47:43 +01:00 committed by David Bremner
parent 87aa5aea56
commit 7e20d26480

View file

@ -320,18 +320,24 @@ modified. This function is notmuch addaptation of
(notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers)) (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
(notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)) (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to))
(message-setup-1 (let ((args (list yank-action send-actions)))
;; The following sexp is copied from `message-mail' ;; message-setup-1 in Emacs 23 does not accept return-action
(nconc ;; argument. Pass it only if it is supplied by the caller. This
`((To . ,(or to "")) (Subject . ,(or subject ""))) ;; will never be the case when we're called by `compose-mail' in
;; C-h f compose-mail says that headers should be specified as ;; Emacs 23.
;; (string . value); however all the rest of message expects (when return-action (nconc args '(return-action)))
;; headers to be symbols, not strings (eg message-header-format-alist). (apply 'message-setup-1
;; http://lists.gnu.org/archive/html/emacs-devel/2011-01/msg00337.html ;; The following sexp is copied from `message-mail'
;; We need to convert any string input, eg from rmail-start-mail. (nconc
(dolist (h other-headers other-headers) `((To . ,(or to "")) (Subject . ,(or subject "")))
(if (stringp (car h)) (setcar h (intern (capitalize (car h))))))) ;; C-h f compose-mail says that headers should be specified as
yank-action send-actions return-action) ;; (string . value); however all the rest of message expects
;; headers to be symbols, not strings (eg message-header-format-alist).
;; http://lists.gnu.org/archive/html/emacs-devel/2011-01/msg00337.html
;; We need to convert any string input, eg from rmail-start-mail.
(dolist (h other-headers other-headers)
(if (stringp (car h)) (setcar h (intern (capitalize (car h)))))))
args))
(notmuch-fcc-header-setup) (notmuch-fcc-header-setup)
(message-sort-headers) (message-sort-headers)
(message-hide-headers) (message-hide-headers)