From 8ae1c3c6e11f7c8d4066ef3d8affe4d07528807b Mon Sep 17 00:00:00 2001 From: Carl Worth Date: Mon, 9 Nov 2009 13:48:58 -0800 Subject: [PATCH] notmuch.el: Don't advance line in search buffer before showing thread. Previously, when selecting a thread to view from the search buffer, we would advance the point by one line before showing the thread, (so that it would be ready to show the next thread once the user was done with the current thread). This was annoying when the user temporarily exited the thread view, (because the "wrong" thread was then selected in the search view). We get a more consistent experience by waiting to advance until the user has finished viewing one thread and is ready to view the next. --- notmuch.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notmuch.el b/notmuch.el index 2e172aae..c8639be5 100644 --- a/notmuch.el +++ b/notmuch.el @@ -184,6 +184,7 @@ Unlike builtin `next-line' this version accepts no arguments." (if parent-buffer (progn (switch-to-buffer parent-buffer) + (forward-line) (notmuch-search-show-thread))))) (defun notmuch-show-mark-read-then-archive-thread () @@ -713,7 +714,6 @@ global search. (defun notmuch-search-show-thread () (interactive) (let ((thread-id (notmuch-search-find-thread-id))) - (forward-line) (if (> (length thread-id) 0) (notmuch-show thread-id (current-buffer)) (error "End of search results"))))