test: retrying lock tests are broken when built against older Xapian

If we're building against a version of Xapian that doesn't offer
retrying the lock, we should be honest and describe the tests as
broken, rather than marking them as missing a test prerequisite.

missing test prerequisites should be for specific components of the
test harness that are missing, not for the backend library notmuch
uses.
This commit is contained in:
Daniel Kahn Gillmor 2017-12-05 21:33:24 -05:00 committed by David Bremner
parent bace15c275
commit 8e1c3fa5bb

View file

@ -2,13 +2,12 @@
test_description="locking"
. $(dirname "$0")/test-lib.sh || exit 1
if [ "${NOTMUCH_HAVE_XAPIAN_DB_RETRY_LOCK}" = "0" ]; then
test_subtest_missing_external_prereq_["lock retry support"]=t
fi
add_email_corpus
test_begin_subtest "blocking open"
if [ $NOTMUCH_HAVE_XAPIAN_DB_RETRY_LOCK -ne 1 ]; then
test_subtest_known_broken
fi
test_C ${MAIL_DIR} <<'EOF'
#include <unistd.h>
#include <stdlib.h>
@ -70,6 +69,9 @@ inbox
parent
unread
EOF
if [ $NOTMUCH_HAVE_XAPIAN_DB_RETRY_LOCK -ne 1 ]; then
test_subtest_known_broken
fi
test_expect_equal_file EXPECTED OUTPUT
test_done