emacs/tag: keep tag history

This buffer local list will be used to provide an undo facility for
tagging operations. Keeping history can be disabled with the new
OMIT-HIST option.
This commit is contained in:
David Bremner 2022-02-12 16:27:38 -04:00
parent d298af9e9d
commit 9b2a548189

View file

@ -275,6 +275,10 @@ This can be used with `notmuch-tag-format-image-data'."
</g> </g>
</svg>") </svg>")
;;; track history of tag operations
(defvar-local notmuch-tag-history nil
"Buffer local history of `notmuch-tag' function.")
;;; Format Handling ;;; Format Handling
(defvar notmuch-tag--format-cache (make-hash-table :test 'equal) (defvar notmuch-tag--format-cache (make-hash-table :test 'equal)
@ -464,12 +468,13 @@ NOTE: this variable is no longer used.")
(make-obsolete-variable 'notmuch-tag-argument-limit nil "notmuch 0.36") (make-obsolete-variable 'notmuch-tag-argument-limit nil "notmuch 0.36")
(defun notmuch-tag (query tag-changes) (defun notmuch-tag (query tag-changes &optional omit-hist)
"Add/remove tags in TAG-CHANGES to messages matching QUERY. "Add/remove tags in TAG-CHANGES to messages matching QUERY.
QUERY should be a string containing the search-terms. QUERY should be a string containing the search-terms.
TAG-CHANGES is a list of strings of the form \"+tag\" or TAG-CHANGES is a list of strings of the form \"+tag\" or \"-tag\"
\"-tag\" to add or remove tags, respectively. to add or remove tags, respectively. OMIT-HIST disables history
tracking if non-nil.
Note: Other code should always use this function to alter tags of Note: Other code should always use this function to alter tags of
messages instead of running (notmuch-call-notmuch-process \"tag\" ..) messages instead of running (notmuch-call-notmuch-process \"tag\" ..)
@ -485,10 +490,14 @@ notmuch-after-tag-hook will be run."
(notmuch-dlet ((tag-changes tag-changes) (notmuch-dlet ((tag-changes tag-changes)
(query query)) (query query))
(run-hooks 'notmuch-before-tag-hook)) (run-hooks 'notmuch-before-tag-hook))
;; Use batch tag mode to avoid argument length limitations (with-temp-buffer
(let ((batch-op (concat (mapconcat #'notmuch-hex-encode tag-changes " ") (insert (concat (mapconcat #'notmuch-hex-encode tag-changes " ") " -- " query))
" -- " query))) (unless (= 0
(notmuch-call-notmuch-process :stdin-string batch-op "tag" "--batch"))) (notmuch--call-process-region
(point-min) (point-max) notmuch-command t t nil "tag" "--batch"))
(notmuch-logged-error "notmuch tag failed" (buffer-string))))
(unless omit-hist
(push (list :query query :tag-changes tag-changes) notmuch-tag-history)))
(notmuch-dlet ((tag-changes tag-changes) (notmuch-dlet ((tag-changes tag-changes)
(query query)) (query query))
(run-hooks 'notmuch-after-tag-hook))) (run-hooks 'notmuch-after-tag-hook)))