debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2025-03-14 03:25:15 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: Return unibyte strings for binary part data

Browse source 
Unibyte strings are meant for representing binary data.  In practice,
using unibyte versus multibyte strings affects *almost* nothing.  It
does happen to matter if we use the binary data in an image descriptor
(which is, helpfully, not documented anywhere and getting it wrong
results in opaque errors like "Not a PNG image: <giant binary spew
that is, in fact, a PNG image>").
This commit is contained in:
Austin Clements 2015-01-24 16:16:59 -05:00 • committed by David Bremner
parent 991efcded8
commit 9d19f325f5
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
emacs/notmuch-lib.el
View file

@ -530,7 +530,7 @@ the given type."
parts))
(defun notmuch-get-bodypart-binary (msg part process-crypto)
"Return the unprocessed content of PART in MSG.
"Return the unprocessed content of PART in MSG as a unibyte string.
This returns the \"raw\" content of the given part after content
transfer decoding, but with no further processing (see the
@ -541,6 +541,16 @@ this does no charset conversion."
,@(when process-crypto '("--decrypt"))
,(notmuch-id-to-query (plist-get msg :id)))))
(with-temp-buffer
;; Emacs internally uses a UTF-8-like multibyte string
;; representation by default (regardless of the coding system,
;; which only affects how it goes from outside data to this
;; internal representation). This *almost* never matters.
;; Annoyingly, it does matter if we use this data in an image
;; descriptor, since Emacs will use its internal data buffer
;; directly and this multibyte representation corrupts binary
;; image formats. Since the caller is asking for binary data, a
;; unibyte string is a more appropriate representation anyway.
(set-buffer-multibyte nil)
(let ((coding-system-for-read 'no-conversion))
(apply #'call-process notmuch-command nil '(t nil) nil args)
(buffer-string)))))