debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-22 02:48:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: replace (funcall 'foo ...) with (foo ...)

Browse source 
I can't see any benefit to the funcall, and it looks like the result
of cut-and-paste from some code that actually used a variable for the
function to call.
This commit is contained in:
David Bremner 2013-06-02 09:16:10 -03:00
parent 5461c31d64
commit 9de0639126
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
emacs/notmuch-message.el
View file

@ -40,7 +40,7 @@ the \"inbox\" and \"todo\" tags, you would set:
;; get the in-reply-to header and parse it for the message id. ;; get the in-reply-to header and parse it for the message id.
(let ((rep (mail-header-parse-addresses (message-field-value "In-Reply-To")))) (let ((rep (mail-header-parse-addresses (message-field-value "In-Reply-To"))))
(when (and notmuch-message-replied-tags rep) (when (and notmuch-message-replied-tags rep)
(funcall 'notmuch-tag (notmuch-id-to-query (car (car rep))) (notmuch-tag (notmuch-id-to-query (car (car rep)))
(notmuch-tag-change-list notmuch-message-replied-tags))))) (notmuch-tag-change-list notmuch-message-replied-tags)))))
(add-hook 'message-send-hook 'notmuch-message-mark-replied) (add-hook 'message-send-hook 'notmuch-message-mark-replied)

6
emacs/notmuch-show.el
View file

@ -1726,7 +1726,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
(let* ((current-tags (notmuch-show-get-tags)) (let* ((current-tags (notmuch-show-get-tags))
(new-tags (notmuch-update-tags current-tags tag-changes))) (new-tags (notmuch-update-tags current-tags tag-changes)))
(unless (equal current-tags new-tags) (unless (equal current-tags new-tags)
(funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes) (notmuch-tag (notmuch-show-get-message-id) tag-changes)
(notmuch-show-set-tags new-tags)))) (notmuch-show-set-tags new-tags))))
(defun notmuch-show-tag (&optional tag-changes) (defun notmuch-show-tag (&optional tag-changes)
@ -1734,7 +1734,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
See `notmuch-tag' for information on the format of TAG-CHANGES." See `notmuch-tag' for information on the format of TAG-CHANGES."
(interactive) (interactive)
(setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes)) (setq tag-changes (notmuch-tag (notmuch-show-get-message-id) tag-changes))
(let* ((current-tags (notmuch-show-get-tags)) (let* ((current-tags (notmuch-show-get-tags))
(new-tags (notmuch-update-tags current-tags tag-changes))) (new-tags (notmuch-update-tags current-tags tag-changes)))
(unless (equal current-tags new-tags) (unless (equal current-tags new-tags)
@ -1745,7 +1745,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
See `notmuch-tag' for information on the format of TAG-CHANGES." See `notmuch-tag' for information on the format of TAG-CHANGES."
(interactive) (interactive)
(setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)) (setq tag-changes (notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes))
(notmuch-show-mapc (notmuch-show-mapc
(lambda () (lambda ()
(let* ((current-tags (notmuch-show-get-tags)) (let* ((current-tags (notmuch-show-get-tags))

4
emacs/notmuch.el
View file

@ -562,7 +562,7 @@ will be signaled."
(defun notmuch-search-tag-region (beg end &optional tag-changes) (defun notmuch-search-tag-region (beg end &optional tag-changes)
"Change tags for threads in the given region." "Change tags for threads in the given region."
(let ((search-string (notmuch-search-find-thread-id-region-search beg end))) (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))
(setq tag-changes (funcall 'notmuch-tag search-string tag-changes)) (setq tag-changes (notmuch-tag search-string tag-changes))
(notmuch-search-foreach-result beg end (notmuch-search-foreach-result beg end
(lambda (pos) (lambda (pos)
(notmuch-search-set-tags (notmuch-search-set-tags
@ -576,7 +576,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
(interactive) (interactive)
(let* ((beg (if (region-active-p) (region-beginning) (point))) (let* ((beg (if (region-active-p) (region-beginning) (point)))
(end (if (region-active-p) (region-end) (point)))) (end (if (region-active-p) (region-end) (point))))
(funcall 'notmuch-search-tag-region beg end tag-changes))) (notmuch-search-tag-region beg end tag-changes)))
(defun notmuch-search-add-tag () (defun notmuch-search-add-tag ()
"Same as `notmuch-search-tag' but sets initial input to '+'." "Same as `notmuch-search-tag' but sets initial input to '+'."