From a4331bf13859a91ee7b95013954be5c68a70815c Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sat, 15 Oct 2016 10:40:48 +0100 Subject: [PATCH 1/3] emacs: fix notmuch-search-line-faces defcustom In commit 2a7b11b064233afc4feead876fa396e3c18a6b91 the default value for notmuch-search-line-faces was changed so that it didn't match the specification in the corresponding defcustom. This meant that it was difficult for the user to customize this variable as they got a type mismatch error. Note anyone who had already customised this variable would not see this bug as their customisation would match the defcustom. --- emacs/notmuch.el | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 8e146924..a7e0f2c1 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -669,9 +669,16 @@ of the result." (goto-char (point-min)) (forward-line (1- notmuch-search-target-line))))))))) +(define-widget 'notmuch--custom-face-edit 'lazy + "Custom face edit with a tag Edit Face" + ;; I could not persuage custom-face-edit to respect the :tag + ;; property so create a widget specially + :tag "Manually specify face" + :type 'custom-face-edit) + (defcustom notmuch-search-line-faces - '(("unread" 'notmuch-search-unread-face) - ("flagged" 'notmuch-search-flagged-face)) + '(("unread" . notmuch-search-unread-face) + ("flagged" . notmuch-search-flagged-face)) "Alist of tags to faces for line highlighting in notmuch-search. Each element looks like (TAG . FACE). A thread with TAG will have FACE applied. @@ -689,7 +696,9 @@ matching tags are merged, with earlier attributes overriding later. A message having both \"deleted\" and \"unread\" tags with the above settings would have a green foreground and blue background." - :type '(alist :key-type (string) :value-type (custom-face-edit)) + :type '(alist :key-type (string) + :value-type (radio (face :tag "Face name") + (notmuch--custom-face-edit))) :group 'notmuch-search :group 'notmuch-faces) From 4c822aecc75bd6f7cdffc80b704b27dde8e27ea6 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Wed, 12 Oct 2016 08:39:21 +0100 Subject: [PATCH 2/3] emacs: search face bugfix In commit 2a7b11b064233afc4feead876fa396e3c18a6b91 the default faces for unread and flagged were accidentally swapped. This swaps them back. --- emacs/notmuch.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index a7e0f2c1..9c7f2020 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -313,7 +313,7 @@ there will be called at other points of notmuch execution." (defface notmuch-search-flagged-face '((t - (:weight bold))) + (:foreground "blue"))) "Face used in search mode face for flagged threads. This face is the default value for the \"flagged\" tag in @@ -323,7 +323,7 @@ This face is the default value for the \"flagged\" tag in (defface notmuch-search-unread-face '((t - (:foreground "blue"))) + (:weight bold))) "Face used in search mode for unread threads. This face is the default value for the \"unread\" tag in From e2e0b451fe92c0419b47478e9d0345916ca239c2 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 11 Oct 2016 23:01:56 -0300 Subject: [PATCH 3/3] NEWS for 0.23.1 --- NEWS | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/NEWS b/NEWS index 1eea5cc5..ac3ceb10 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,22 @@ +Notmuch 0.23.1 (UNRELEASED) +=========================== + +General +------- + +Require Xapian >= 1.2.6 + + The ifdef branch for older Xapian (pre-compact API) had bit-rotted. + +Emacs +----- + +Fix test failure with Emacs 25.1 + + A previously undiscovered jit-lock related bug was exposed by Emacs + 25, causing a notmuch-show mode test to fail. This release fixes the + bug, and hence the test. + Notmuch 0.23 (2016-10-03) =========================