test/crypto: clarify the difference between ownertrust and validity

This is a subtle difference, but the output of notmuch shouldn't ever
change based on ownertrust itself -- notmuch is intended to show valid
User IDs, and to avoid showing invalid User IDs.

It so happens that setting ownertrust of a key to ultimate sets all
associated user IDs to "full" validity, so the test is correct, but
just misnamed.

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
This commit is contained in:
Daniel Kahn Gillmor 2019-05-04 17:33:26 -04:00 committed by David Bremner
parent 5642efb720
commit 9f05ceb994

View file

@ -135,8 +135,9 @@ test_expect_equal_json \
"$output" \ "$output" \
"$expected" "$expected"
test_begin_subtest "signature verification with full owner trust" test_begin_subtest "signature verification with full user ID validity"
# give the key full owner trust # give the key ultimate owner trust, which confers full validity on
# all user IDs in the certificate:
echo "${FINGERPRINT}:6:" | gpg --no-tty --import-ownertrust >>"$GNUPGHOME"/trust.log 2>&1 echo "${FINGERPRINT}:6:" | gpg --no-tty --import-ownertrust >>"$GNUPGHOME"/trust.log 2>&1
gpg --no-tty --check-trustdb >>"$GNUPGHOME"/trust.log 2>&1 gpg --no-tty --check-trustdb >>"$GNUPGHOME"/trust.log 2>&1
output=$(notmuch show --format=json --verify subject:"test signed message 001" \ output=$(notmuch show --format=json --verify subject:"test signed message 001" \