debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-12-22 17:34:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions

Browse source 
Recent changes in notmuch-show tagging introduced some code
duplication.  The patch cleanups and simplifies
`notmuch-show-archive-thread' function by using
`notmuch-show-tag-all', no longer used function are removed.  After
the change, `notmuch-show-archive-thread' function becomes symmetric
with `notmuch-show-archive-message'.

A side effect of these changes is that `notmuch-show-archive-thread'
no longer calls "notmuch tag" for each message in the thread.
This commit is contained in:
Dmitry Kurochkin 2012-02-08 20:48:51 +04:00 committed by David Bremner
parent 668b66ec85
commit a5674c2158
1 changed files with 2 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
emacs/notmuch-show.el
View file

@ -1690,26 +1690,6 @@ argument, hide all of the messages."
(interactive)
(backward-button 1))
(defun notmuch-show-tag-thread-internal (tag &optional remove)
"Add tag to the current set of messages.
If the remove switch is given, tags will be removed instead of
added."
(goto-char (point-min))
(let ((op (if remove "-" "+")))
(loop do (notmuch-show-tag-message (concat op tag))
until (not (notmuch-show-goto-message-next)))))
(defun notmuch-show-add-tag-thread (tag)
"Add tag to all messages in the current thread."
(interactive)
(notmuch-show-tag-thread-internal tag))
(defun notmuch-show-remove-tag-thread (tag)
"Remove tag from all messages in the current thread."
(interactive)
(notmuch-show-tag-thread-internal tag t))
(defun notmuch-show-next-thread (&optional show-next)
"Move to the next item in the search results, if any."
(interactive "P")
@ -1737,9 +1717,8 @@ being delivered to the same thread. It does not archive the
entire thread, but only the messages shown in the current
buffer."
(interactive "P")
(if unarchive
(notmuch-show-add-tag-thread "inbox")
(notmuch-show-remove-tag-thread "inbox")))
(let ((op (if unarchive "+" "-")))
(notmuch-show-tag-all (concat op "inbox"))))
(defun notmuch-show-archive-thread-then-next ()
"Archive each message in thread, then show next thread from search."