debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-25 12:28:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

smtp-dummy: Prefer return rather than exit() in main.

Browse source 
The main() function should be written as just another function with a
return value. This allows for more reliable code reuse. Imagine that
main() grows too large and needs to be factored into multiple
functions. At that point, exit() is probably the wrong thing, yet can
also be hard to notice as it's in less-frequently-tested exceptional
cases.
This commit is contained in:
Carl Worth 2011-06-21 14:54:10 -07:00
parent 41a094624a
commit b0ba84f9e7
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
test/smtp-dummy.c
View file

@ -127,7 +127,7 @@ main (int argc, char *argv[])
if (argc != 2) { if (argc != 2) {
fprintf (stderr, "Usage: %s <output-file>\n", argv[0]); fprintf (stderr, "Usage: %s <output-file>\n", argv[0]);
exit (1); return 1;
} }
output_filename = argv[1]; output_filename = argv[1];
@ -135,14 +135,14 @@ main (int argc, char *argv[])
if (output == NULL) { if (output == NULL) {
fprintf (stderr, "Failed to open %s for writing: %s\n", fprintf (stderr, "Failed to open %s for writing: %s\n",
output_filename, strerror (errno)); output_filename, strerror (errno));
exit (1); return 1;
} }
sock = socket (AF_INET, SOCK_STREAM, 0); sock = socket (AF_INET, SOCK_STREAM, 0);
if (sock == -1) { if (sock == -1) {
fprintf (stderr, "Error: socket() failed: %s\n", fprintf (stderr, "Error: socket() failed: %s\n",
strerror (errno)); strerror (errno));
exit (1); return 1;
} }
reuse = 1; reuse = 1;
@ -150,13 +150,13 @@ main (int argc, char *argv[])
if (err) { if (err) {
fprintf (stderr, "Error: setsockopt() failed: %s\n", fprintf (stderr, "Error: setsockopt() failed: %s\n",
strerror (errno)); strerror (errno));
exit (1); return 1;
} }
hostinfo = gethostbyname ("localhost"); hostinfo = gethostbyname ("localhost");
if (hostinfo == NULL) { if (hostinfo == NULL) {
fprintf (stderr, "Unknown host: localhost\n"); fprintf (stderr, "Unknown host: localhost\n");
exit (1); return 1;
} }
addr.sin_family = AF_INET; addr.sin_family = AF_INET;
@ -167,7 +167,7 @@ main (int argc, char *argv[])
fprintf (stderr, "Error: bind() failed: %s\n", fprintf (stderr, "Error: bind() failed: %s\n",
strerror (errno)); strerror (errno));
close (sock); close (sock);
exit (1); return 1;
} }
err = listen (sock, 1); err = listen (sock, 1);
@ -175,7 +175,7 @@ main (int argc, char *argv[])
fprintf (stderr, "Error: listen() failed: %s\n", fprintf (stderr, "Error: listen() failed: %s\n",
strerror (errno)); strerror (errno));
close (sock); close (sock);
exit (1); return 1;
} }
peer_addr_len = sizeof (peer_addr); peer_addr_len = sizeof (peer_addr);
@ -183,14 +183,14 @@ main (int argc, char *argv[])
if (peer == -1) { if (peer == -1) {
fprintf (stderr, "Error: accept() failed: %s\n", fprintf (stderr, "Error: accept() failed: %s\n",
strerror (errno)); strerror (errno));
exit (1); return 1;
} }
peer_file = fdopen (peer, "w+"); peer_file = fdopen (peer, "w+");
if (peer_file == NULL) { if (peer_file == NULL) {
fprintf (stderr, "Error: fdopen() failed: %s\n", fprintf (stderr, "Error: fdopen() failed: %s\n",
strerror (errno)); strerror (errno));
exit (1); return 1;
} }
do_smtp_to_file (peer_file, output); do_smtp_to_file (peer_file, output);