debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-25 20:38:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: jump: fix compile warning on emacs 23

Browse source 
notmuch-jump uses window-body-width which is not defined in emacs
23. To get around this it does

(unless (fboundp 'window-body-width)
  ;; Compatibility for Emacs pre-24
  (defalias 'window-body-width 'window-width))

This makes sure window-body-width is defined and all should be
well. But it seems that the byte compiler does not realise that this
guarantees that window-body-width will be defined and so, when
compiling with emacs 23, it gives an error

In end of data:
notmuch-jump.el:172:1:Warning: the function `window-body-width' is not known to be defined.

Domo and I came to following on irc: wrap the (unless (fboundp ...))
inside eval-and-compile which ensures that both the test and the
defalias (if needed) happen at both compile and load time.  This fixes
the warning.
This commit is contained in:
Mark Walters 2014-09-04 10:46:54 +01:00 committed by David Bremner
parent e13d557bfd
commit b2caa125ee
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
emacs/notmuch-jump.el
View file

@ -25,9 +25,10 @@
(require 'notmuch-lib) (require 'notmuch-lib)
(require 'notmuch-hello) (require 'notmuch-hello)
(unless (fboundp 'window-body-width) (eval-and-compile
;; Compatibility for Emacs pre-24 (unless (fboundp 'window-body-width)
(defalias 'window-body-width 'window-width)) ;; Compatibility for Emacs pre-24
(defalias 'window-body-width 'window-width)))
;;;###autoload ;;;###autoload
(defun notmuch-jump-search () (defun notmuch-jump-search ()