debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-24 20:08:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: Use single-quote not double-quote when constructing search

Browse source 
Commit 44982ab332 added some extra
quoting when constructing a search. A previous version of this patch
had used single-quotation marks (') while this version used
double-quotation marks (").

The intent of the extra quoting was to allow notmuch-command to be set
to a script invoking ssh.

What actually happens, however is that the extra quotation marks make
it all the way into the query string seen by Xapian. And the double
quotes trigger phrase searching, (which isn't desired here). The
side-effect of that is that the emacs code would fallback to an
unqalified query and display all threads with all messages open.

We fix that side-effect now by using single-quote characters, but
we'll want a better fix in the future to avoid Xapian seeing these
characters at all I think.
This commit is contained in:
Carl Worth 2010-04-23 16:39:18 -07:00
parent 45ad21fba1
commit b57d9635f5
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
emacs/notmuch-show.el
View file

@ -470,8 +470,8 @@ function is used. "
(save-excursion (save-excursion
(let* ((basic-args (list thread-id)) (let* ((basic-args (list thread-id))
(args (if query-context (args (if query-context
(append (list "\"") basic-args (list "and (" query-context ")\"")) (append (list "\'") basic-args (list "and (" query-context ")\'"))
(append (list "\"") basic-args (list "\""))))) (append (list "\'") basic-args (list "\'")))))
(notmuch-show-insert-forest (notmuch-query-get-threads args)) (notmuch-show-insert-forest (notmuch-query-get-threads args))
;; If the query context reduced the results to nothing, run ;; If the query context reduced the results to nothing, run
;; the basic query. ;; the basic query.