debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-21 18:38:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: notmuch-show-view-raw-message clears buffer, makes it read-only

Browse source 
notmuch-show-view-raw-message() re-uses buffer created with same
name (same Message-Id:) but it did not erase it before filling.
If this ever happened, there were duplicated (potentially overlapping)
content in the buffer. Now this is fixed.
Apparently since emacs 24.5 the (view-buffer) makes the buffer read-only;
so this problem would not have happened there, just that
notmuch-show-view-raw-message() failed. This is fixed by setting
inhibit-read-only t before erasing and filling the buffer. The emacs 24.5
feature having raw message buffer read-only is also now explicitly set to
the buffer so the same experience is available with emaces < 24.5.
This commit is contained in:
Tomi Ollila 2015-09-02 17:34:39 +03:00 committed by David Bremner
parent 40325352db
commit bfb7098514
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
emacs/notmuch-show.el
View file

@ -1878,12 +1878,15 @@ to show, nil otherwise."
"View the original source of the current message." "View the original source of the current message."
(interactive) (interactive)
(let* ((id (notmuch-show-get-message-id)) (let* ((id (notmuch-show-get-message-id))
(buf (get-buffer-create (concat "*notmuch-raw-" id "*")))) (buf (get-buffer-create (concat "*notmuch-raw-" id "*")))
(let ((coding-system-for-read 'no-conversion)) (inhibit-read-only t))
(call-process notmuch-command nil buf nil "show" "--format=raw" id))
(switch-to-buffer buf) (switch-to-buffer buf)
(erase-buffer)
(let ((coding-system-for-read 'no-conversion))
(call-process notmuch-command nil t nil "show" "--format=raw" id))
(goto-char (point-min)) (goto-char (point-min))
(set-buffer-modified-p nil) (set-buffer-modified-p nil)
(setq buffer-read-only t)
(view-buffer buf 'kill-buffer-if-not-modified))) (view-buffer buf 'kill-buffer-if-not-modified)))
(put 'notmuch-show-pipe-message 'notmuch-doc (put 'notmuch-show-pipe-message 'notmuch-doc