debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2025-01-03 07:11:41 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: derive correct timestamp in FCC unique name

Browse source 
Previously, the timestamp at the beginning of the FCC unique maildir
name was derived incorrectly, thanks to an integer overflow. This
changes the derivation of timestamp to use a float, and so will get
the number correct at least until 2038. (It is still formatted with
"%d" so it will show up as an integer.) Should we need to change it in
the next 26 years to take the unix millenium into account, it will be
invisible to users.

This change is mostly a question of consistency, since the unique name
is arbitrary anyway. But since most people use timestamps, and that was
the original intention here as well, we might as well.

Signed-off-by: Jesse Rosenthal <jrosenthal@jhu.edu>
This commit is contained in:
Jesse Rosenthal 2012-06-14 13:16:03 -04:00 committed by David Bremner
parent a7bc1c7bc5
commit d094153a26
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
emacs/notmuch-maildir-fcc.el
View file

@ -140,13 +140,12 @@ will NOT be removed or replaced."
t)) t))
(defun notmuch-maildir-fcc-make-uniq-maildir-id () (defun notmuch-maildir-fcc-make-uniq-maildir-id ()
(let* ((ct (current-time)) (let* ((ftime (float-time))
(timeid (+ (* (car ct) 65536) (cadr ct))) (microseconds (mod (* 1000000 ftime) 1000000))
(microseconds (car (cdr (cdr ct))))
(hostname (notmuch-maildir-fcc-host-fixer system-name))) (hostname (notmuch-maildir-fcc-host-fixer system-name)))
(setq notmuch-maildir-fcc-count (+ notmuch-maildir-fcc-count 1)) (setq notmuch-maildir-fcc-count (+ notmuch-maildir-fcc-count 1))
(format "%d.%d_%d_%d.%s" (format "%d.%d_%d_%d.%s"
timeid ftime
(emacs-pid) (emacs-pid)
microseconds microseconds
notmuch-maildir-fcc-count notmuch-maildir-fcc-count