debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2025-02-17 23:53:15 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Avoid spurious gcc warning in debugger.c

Browse source 
Without this patch, gcc 8.2.0-7 complains:

debugger.c: In function ‘debugger_is_active’:
debugger.c:40:24: warning: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Wrestrict]
     if (readlink (buf, buf, sizeof (buf)) != -1 &&
                   ~~~  ^~~

This is pretty silly, but it seems simplest to just avoid passing the
same buffer to readlink as both pathname and buf.
This commit is contained in:
Daniel Kahn Gillmor 2018-10-06 15:34:49 -05:00 • committed by David Bremner
parent f5411574af
commit daec80eeda
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
debugger.c
View file

@ -32,13 +32,14 @@ bool
debugger_is_active (void) debugger_is_active (void)
{ {
char buf[1024]; char buf[1024];
char buf2[1024];
if (RUNNING_ON_VALGRIND) if (RUNNING_ON_VALGRIND)
return true; return true;
sprintf (buf, "/proc/%d/exe", getppid ()); sprintf (buf, "/proc/%d/exe", getppid ());
if (readlink (buf, buf, sizeof (buf)) != -1 && if (readlink (buf, buf2, sizeof (buf2)) != -1 &&
strncmp (basename (buf), "gdb", 3) == 0) strncmp (basename (buf2), "gdb", 3) == 0)
{ {
return true; return true;
} }