debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-25 12:28:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

configure: disallow whitespace in paths, extend checks to $PWD

Browse source 
Whitespace in $NOTMUCH_SRCDIR (and $PWD) may work in builds,
but definitely will not work in tests. It would be difficult
to make tests support whitespace in test filename paths -- and
fragile to maintain if done.

So it is just easier and safer to disallow whitespace there.

In case of out of tree build $NOTMUCH_SRCDIR differs from $PWD
(current directory). Extend this whitespace, and also previously
made unsafe characters check to $PWD too.
This commit is contained in:
Tomi Ollila 2019-09-01 23:09:46 +03:00 committed by David Bremner
parent 9829533e92
commit e0e55c5b6f
1 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
configure vendored
View file

@ -31,6 +31,22 @@ case $NOTMUCH_SRCDIR in ( *\'* | *['\"`$']* )
exit 1 exit 1
esac esac
case $PWD in ( *\'* | *['\"`$']* )
echo "Definitely unsafe characters in current directory '$PWD'".
exit 1
esac
# In case of whitespace, builds may work, tests definitely will not.
case $NOTMUCH_SRCDIR in ( *["$IFS"]* )
echo "Whitespace in source path '$NOTMUCH_SRCDIR' not supported".
exit 1
esac
case $PWD in ( *["$IFS"]* )
echo "Whitespace in current directory '$PWD' not supported".
exit 1
esac
subdirs="util compat lib parse-time-string completion doc emacs" subdirs="util compat lib parse-time-string completion doc emacs"
subdirs="${subdirs} performance-test test test/test-databases" subdirs="${subdirs} performance-test test test/test-databases"
subdirs="${subdirs} bindings" subdirs="${subdirs} bindings"