From e311aad182326a1dcb0f8512e10b0e0f0faa9e2c Mon Sep 17 00:00:00 2001 From: David Bremner Date: Fri, 8 Apr 2016 22:49:50 -0300 Subject: [PATCH] test: cope with glass backend file naming variations In several places in the test suite we intentionally corrupt the Xapian database in order to test error handling. This corruption is specific to the on-disk organization of the database, and that changed with the glass backend. We use the previously computed default backend to make the tests adapt to changing names. --- test/T050-new.sh | 4 ++-- test/T060-count.sh | 4 ++-- test/T150-tagging.sh | 4 ++-- test/T360-symbol-hiding.sh | 4 ++-- test/T560-lib-error.sh | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/test/T050-new.sh b/test/T050-new.sh index 93a6fa94..f38e6263 100755 --- a/test/T050-new.sh +++ b/test/T050-new.sh @@ -284,9 +284,9 @@ notmuch config set new.tags $OLDCONFIG test_begin_subtest "Xapian exception: read only files" -chmod u-w ${MAIL_DIR}/.notmuch/xapian/*.DB +chmod u-w ${MAIL_DIR}/.notmuch/xapian/*.${db_ending} output=$(NOTMUCH_NEW --debug 2>&1 | sed 's/: .*$//' ) -chmod u+w ${MAIL_DIR}/.notmuch/xapian/*.DB +chmod u+w ${MAIL_DIR}/.notmuch/xapian/*.${db_ending} test_expect_equal "$output" "A Xapian exception occurred opening database" test_done diff --git a/test/T060-count.sh b/test/T060-count.sh index 3fec94e8..0ac83140 100755 --- a/test/T060-count.sh +++ b/test/T060-count.sh @@ -95,7 +95,7 @@ test_expect_equal_file EXPECTED OUTPUT backup_database test_begin_subtest "error message for database open" -dd if=/dev/zero of="${MAIL_DIR}/.notmuch/xapian/postlist.DB" count=3 +dd if=/dev/zero of="${MAIL_DIR}/.notmuch/xapian/postlist.${db_ending}" count=3 notmuch count '*' 2>OUTPUT 1>/dev/null output=$(sed 's/^\(A Xapian exception [^:]*\):.*$/\1/' OUTPUT) test_expect_equal "${output}" "A Xapian exception occurred opening database" @@ -105,7 +105,7 @@ cat < count-files.gdb set breakpoint pending on break count_files commands -shell cp /dev/null ${MAIL_DIR}/.notmuch/xapian/postlist.DB +shell cp /dev/null ${MAIL_DIR}/.notmuch/xapian/postlist.${db_ending} continue end run diff --git a/test/T150-tagging.sh b/test/T150-tagging.sh index 8adcabce..a451ffae 100755 --- a/test/T150-tagging.sh +++ b/test/T150-tagging.sh @@ -287,9 +287,9 @@ test_expect_code 1 "Empty tag names" 'notmuch tag + One' test_expect_code 1 "Tag name beginning with -" 'notmuch tag +- One' test_begin_subtest "Xapian exception: read only files" -chmod u-w ${MAIL_DIR}/.notmuch/xapian/*.DB +chmod u-w ${MAIL_DIR}/.notmuch/xapian/*.${db_ending} output=$(notmuch tag +something '*' 2>&1 | sed 's/: .*$//' ) -chmod u+w ${MAIL_DIR}/.notmuch/xapian/*.DB +chmod u+w ${MAIL_DIR}/.notmuch/xapian/*.${db_ending} test_expect_equal "$output" "A Xapian exception occurred opening database" test_done diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh index 89e7f165..3f18ec1a 100755 --- a/test/T360-symbol-hiding.sh +++ b/test/T360-symbol-hiding.sh @@ -15,11 +15,11 @@ test_begin_subtest 'running test' run_test mkdir -p ${PWD}/fakedb/.notmuch ( LD_LIBRARY_PATH="$TEST_DIRECTORY/../lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" \ $TEST_DIRECTORY/symbol-test ${PWD}/fakedb ${PWD}/nonexistent \ - 2>&1 | notmuch_dir_sanitize | sed "s,\`,\',g") > OUTPUT + 2>&1 | notmuch_dir_sanitize | sed -e "s,\`,\',g" -e "s,${NOTMUCH_DEFAULT_XAPIAN_BACKEND},backend,g") > OUTPUT cat < EXPECTED A Xapian exception occurred opening database: Couldn't stat 'CWD/fakedb/.notmuch/xapian' -caught No chert database found at path 'CWD/nonexistent' +caught No backend database found at path 'CWD/nonexistent' EOF test_expect_equal_file EXPECTED OUTPUT diff --git a/test/T560-lib-error.sh b/test/T560-lib-error.sh index 49d36740..087c6bd7 100755 --- a/test/T560-lib-error.sh +++ b/test/T560-lib-error.sh @@ -189,7 +189,7 @@ Path already exists: MAIL_DIR EOF test_expect_equal_file EXPECTED OUTPUT -cat <<'EOF' > c_head +cat < c_head #include #include #include @@ -210,7 +210,7 @@ int main (int argc, char** argv) fprintf (stderr, "error opening database: %d %s\n", stat, msg ? msg : ""); exit (1); } - path = talloc_asprintf (db, "%s/.notmuch/xapian/postlist.DB", argv[1]); + path = talloc_asprintf (db, "%s/.notmuch/xapian/postlist.${db_ending}", argv[1]); fd = open(path,O_WRONLY|O_TRUNC); if (fd < 0) { fprintf (stderr, "error opening %s\n", argv[1]);