debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-12-22 01:14:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs/show: obey notmuch-show-max-text-part-size for part 0

Browse source 
This parameter was originally introduced to hide large attachements
that happened to be text/plain. From a performance point of view,
there is no reason not to also hide large message bodies.
This commit is contained in:
David Bremner 2022-06-27 22:02:03 -03:00
parent 1d254bd35e
commit e580ce0058
5 changed files with 175 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
doc/notmuch-emacs.rst
View file

@ -280,6 +280,9 @@ Display of messages can be controlled by the following variables
:index:`notmuch-show-depth-limit`
|docstring::notmuch-show-depth-limit|
:index:`notmuch-show-max-text-part-size`
|docstring::notmuch-show-max-text-part-size|
:index:`notmuch-multipart/alternative-discouraged`
Which mime types to hide by default for multipart messages.

2
emacs/notmuch-show.el
View file

@ -1048,7 +1048,7 @@ is t, hide the part initially and show the button."
(beg (point))
;; This default header-p function omits the part button for
;; the first (or only) part if this is text/plain.
(button (and (or deep
(button (and (or deep long
(funcall notmuch-show-insert-header-p-function part hide))
(notmuch-show-insert-part-header
nth mime-type

18
test/T450-emacs-show.sh
View file

@ -109,6 +109,24 @@ test_emacs '(let ((notmuch-show-depth-limit 1))
(test-visible-output))'
test_expect_equal_file $EXPECTED/notmuch-show-depth-1 OUTPUT
test_begin_subtest "Hide bodies of messages by size"
test_emacs '(let ((notmuch-show-max-text-part-size 1))
(notmuch-search "thread:{id:87ocn0qh6d.fsf@yoom.home.cworth.org}")
(notmuch-test-wait)
(notmuch-search-show-thread)
(notmuch-test-wait)
(test-visible-output))'
test_expect_equal_file $EXPECTED/notmuch-show-size OUTPUT
test_begin_subtest "Hide bodies of messages by size > 450"
test_emacs '(let ((notmuch-show-max-text-part-size 450))
(notmuch-search "thread:{id:87ocn0qh6d.fsf@yoom.home.cworth.org}")
(notmuch-test-wait)
(notmuch-search-show-thread)
(notmuch-test-wait)
(test-visible-output))'
test_expect_equal_file $EXPECTED/notmuch-show-size-450 OUTPUT
test_begin_subtest "notmuch-show: elide non-matching messages (w/ notmuch-show-toggle-elide-non-matching)"
test_emacs '(let ((notmuch-show-only-matching-messages nil))
(notmuch-search "from:lars@seas.harvard.edu and subject:\"Maildir storage\"")

64
test/emacs-show.expected-output/notmuch-show-size Normal file
View file

@ -0,0 +1,64 @@
Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
Subject: [notmuch] Working with Maildir storage?
To: notmuch@notmuchmail.org
Date: Tue, 17 Nov 2009 14:00:54 -0500
[ multipart/mixed ]
[ multipart/signed ]
[ Unknown key ID 0xD74695063141ACD8 or unsupported algorithm ]
[ text/plain (hidden) ]
[ application/pgp-signature ]
[ text/plain (hidden) ]
Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
Subject: Re: [notmuch] Working with Maildir storage?
To: notmuch@notmuchmail.org
Date: Wed, 18 Nov 2009 01:02:38 +0600
[ multipart/mixed ]
[ multipart/signed ]
[ Unknown key ID 0x9D20F6503E338888 or unsupported algorithm ]
[ text/plain (hidden) ]
[ application/pgp-signature ]
[ text/plain (hidden) ]
Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
Subject: Re: [notmuch] Working with Maildir storage?
To: Mikhail Gusarov <dottedmag@dottedmag.net>
Cc: notmuch@notmuchmail.org
Date: Tue, 17 Nov 2009 15:33:01 -0500
[ multipart/mixed ]
[ multipart/signed ]
[ Unknown key ID 0xD74695063141ACD8 or unsupported algorithm ]
[ text/plain (hidden) ]
[ application/pgp-signature ]
[ text/plain (hidden) ]
Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
Subject: [notmuch] Working with Maildir storage?
To: notmuch@notmuchmail.org
Date: Wed, 18 Nov 2009 02:50:48 +0600
[ text/plain (hidden) ]
Keith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
Subject: [notmuch] Working with Maildir storage?
To: notmuch@notmuchmail.org
Date: Tue, 17 Nov 2009 13:24:13 -0800
[ text/plain (hidden) ]
Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
Subject: Re: [notmuch] Working with Maildir storage?
To: Keith Packard <keithp@keithp.com>
Cc: notmuch@notmuchmail.org
Date: Tue, 17 Nov 2009 19:50:40 -0500
[ multipart/mixed ]
[ multipart/signed ]
[ Unknown key ID 0xD74695063141ACD8 or unsupported algorithm ]
[ text/plain (hidden) ]
[ application/pgp-signature ]
[ text/plain (hidden) ]
Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
Subject: [notmuch] Working with Maildir storage?
To: notmuch@notmuchmail.org
Date: Wed, 18 Nov 2009 02:08:10 -0800
[ text/plain (hidden) ]

89
test/emacs-show.expected-output/notmuch-show-size-450 Normal file
View file

@ -0,0 +1,89 @@
Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
Subject: [notmuch] Working with Maildir storage?
To: notmuch@notmuchmail.org
Date: Tue, 17 Nov 2009 14:00:54 -0500
[ multipart/mixed ]
[ multipart/signed ]
[ Unknown key ID 0xD74695063141ACD8 or unsupported algorithm ]
[ text/plain (hidden) ]
[ application/pgp-signature ]
[ text/plain ]
[ 4-line signature. Click/Enter to show. ]
Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
Subject: Re: [notmuch] Working with Maildir storage?
To: notmuch@notmuchmail.org
Date: Wed, 18 Nov 2009 01:02:38 +0600
[ multipart/mixed ]
[ multipart/signed ]
[ Unknown key ID 0x9D20F6503E338888 or unsupported algorithm ]
[ text/plain ]
Twas brillig at 14:00:54 17.11.2009 UTC-05 when lars@seas.harvard.edu did
gyre and gimble:
LK> Resulted in 4604 lines of errors along the lines of:
LK> Error opening
LK>
/home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
LK> Too many open files
See the patch just posted here.
[ 2-line signature. Click/Enter to show. ]
[ application/pgp-signature ]
[ text/plain ]
[ 4-line signature. Click/Enter to show. ]
Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
Subject: Re: [notmuch] Working with Maildir storage?
To: Mikhail Gusarov <dottedmag@dottedmag.net>
Cc: notmuch@notmuchmail.org
Date: Tue, 17 Nov 2009 15:33:01 -0500
[ multipart/mixed ]
[ multipart/signed ]
[ Unknown key ID 0xD74695063141ACD8 or unsupported algorithm ]
[ text/plain (hidden) ]
[ application/pgp-signature ]
[ text/plain ]
[ 4-line signature. Click/Enter to show. ]
Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
Subject: [notmuch] Working with Maildir storage?
To: notmuch@notmuchmail.org
Date: Wed, 18 Nov 2009 02:50:48 +0600
[ text/plain (hidden) ]
Keith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
Subject: [notmuch] Working with Maildir storage?
To: notmuch@notmuchmail.org
Date: Tue, 17 Nov 2009 13:24:13 -0800
[ text/plain (hidden) ]
Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
Subject: Re: [notmuch] Working with Maildir storage?
To: Keith Packard <keithp@keithp.com>
Cc: notmuch@notmuchmail.org
Date: Tue, 17 Nov 2009 19:50:40 -0500
[ multipart/mixed ]
[ multipart/signed ]
[ Unknown key ID 0xD74695063141ACD8 or unsupported algorithm ]
[ text/plain ]
> I've also pushed a slightly more complicated (and complete) fix to my
> private notmuch repository
The version of lib/messages.cc in your repo doesn't build because it's
missing "#include <stdint.h>" (for the uint32_t on line 466).
[ 4-line signature. Click/Enter to show. ]
[ application/pgp-signature ]
[ text/plain ]
[ 4-line signature. Click/Enter to show. ]
Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
Subject: [notmuch] Working with Maildir storage?
To: notmuch@notmuchmail.org
Date: Wed, 18 Nov 2009 02:08:10 -0800
[ text/plain (hidden) ]