debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-22 19:08:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: Fix trimming regexp in notmuch-check-exit-status

Browse source 
For such a simple regexp, this was broken in a very complicated way.

The intent was to strip the newline (and potentially other whitespace)
off the end of the error string so there wasn't an extra newline in
the error signal.  However, the regexp was deeply dependent on the
active syntax table and the subtleties of $.  We didn't notice this
because all notmuch major modes put ?\n in the whitespace class, which
makes this behaved as intended: the "\\s " matches all newlines, but
by matching the newline character, causes the $ *not* to match
*except* where it matched the empty string at the very end of the
string, which was not followed by a newline.

However, if the syntax table declares ?\n to be non-whitespace
(lisp-mode declares it as endcomment, and is likely to be the mode
you're in when testing functions), then this regexp behaves completely
differently, matching trailing spaces at the end of every line within
the string.

The solution is to say what we mean for whitespace *and* to switch
from $ to \', which matches only the end of the string, rather than
the end of each line.  Both are necessary or this will strip away
interior newlines, which is not what we want.
This commit is contained in:
Austin Clements 2013-05-17 16:14:03 -04:00 committed by David Bremner
parent 2cbd68de92
commit e7ade21d56
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
emacs/notmuch-lib.el
View file

@ -438,7 +438,7 @@ You may need to restart Emacs or upgrade your notmuch package."))
(if err (if err
;; We have an error message straight from the CLI. ;; We have an error message straight from the CLI.
(notmuch-logged-error (notmuch-logged-error
(replace-regexp-in-string "\\s $" "" err) extra) (replace-regexp-in-string "[ \n\r\t\f]*\\'" "" err) extra)
;; We only have combined output from the CLI; don't inundate ;; We only have combined output from the CLI; don't inundate
;; the user with it. Mimic `process-lines'. ;; the user with it. Mimic `process-lines'.
(notmuch-logged-error (format "%s exited with status %s" (notmuch-logged-error (format "%s exited with status %s"