emacs: show: lazy part handling bugfix

The lazy part handler had a bug that it allowed the button to be
toggled to be specified. During toggling it needs to save and restore
the text-properties for the button but it actually saved the text
properties at point rather than from the button.

In almost all cases this didn't matter as as point had the same text
properties as the button. However, it is a bug and did cause incorrect
behaviour in some cases: see id:87txhz14z6.fsf@qmul.ac.uk for details.
This commit is contained in:
Mark Walters 2013-09-07 00:28:45 +01:00 committed by David Bremner
parent f3dc5be6f2
commit ee8305b519

View file

@ -470,7 +470,7 @@ message at DEPTH in the current thread."
(new-start (button-start button))
(button-label (button-get button :base-label))
(old-point (point))
(properties (text-properties-at (point)))
(properties (text-properties-at (button-start button)))
(inhibit-read-only t))
;; Toggle the button itself.
(button-put button :notmuch-part-hidden (not show))