From fa0bc2ef91cf5c5a86ac24cd76383be3b1819cee Mon Sep 17 00:00:00 2001 From: Daniel Kahn Gillmor Date: Wed, 10 Feb 2016 11:53:46 -0500 Subject: [PATCH] notmuch.Database.remove_message should raise exception on failure The notmuch python bindings document that database.remove_message should raise an exception when the message removal fails, but they don't actually do it. --- bindings/python/notmuch/database.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py index 93e7b7a1..f3045334 100644 --- a/bindings/python/notmuch/database.py +++ b/bindings/python/notmuch/database.py @@ -483,7 +483,10 @@ class Database(object): removed. """ self._assert_db_is_initialized() - return self._remove_message(self._db, _str(filename)) + status = self._remove_message(self._db, _str(filename)) + if status not in [STATUS.SUCCESS, STATUS.DUPLICATE_MESSAGE_ID]: + raise NotmuchError(status) + return status def find_message(self, msgid): """Returns a :class:`Message` as identified by its message ID