Commit graph

5653 commits

Author SHA1 Message Date
Yuri Volchkov
02761b2e5c test: remove remainder of previously killed basic test
In the commit 51cd69feb1 the part of the
test "test runs if prerequisite is satisfied" has been
removed. However, there was a remainder of that test - variable
'haveit'.

Kill it, to not to confuse people.

Signed-off-by: Yuri Volchkov <yuri.volchkov@gmail.com>
2017-08-18 19:45:17 -03:00
Vladimir Panteleev
ca4688e103 Use rooted paths in .gitignore files
A leading / in paths in a .gitignore file matches the beginning of the
path, meaning that for patterns without slashes, git will match files
only in the current directory as opposed to in any subdirectory.

Prefix relevant paths with / in .gitignore files, to prevent
accidentally ignoring files in subdirectories and possibly slightly
improve the performance of "git status".
2017-08-18 19:42:35 -03:00
Vladimir Panteleev
4d44976135 test: Update extant references to corpus.mail
971cdc72cd renamed corpus.mail to
corpora.mail. Although 971cdc72cd
updated some of the remaining corpus.mail references, two remained,
causing the test suite to leave behind an unignored corpora.mail
directory.
2017-08-18 19:42:19 -03:00
Daniel Kahn Gillmor
23eed88e32 remove boolean "first" argument from format_part_sprinter
This argument seems to be unused, and format_part_sprinter isn't
required to meet any specific API so it seems cleaner and simpler to
drop it.
2017-08-16 21:56:58 -03:00
David Bremner
f385055528 test: add test for ,S message without 'unread' in new.tags
This is arguably overkill, but it helps to understand the complicated
interactions here between maildir tags and configuration.
2017-08-16 21:53:43 -03:00
David Bremner
e1f9ab4849 test: add missing quotes in maildir-sync test.
Oops. ';' is significant in the shell. Who knew.
2017-08-16 21:48:51 -03:00
David Bremner
9836a8f42b Merge branch 'release'
merge in debian-only changes
2017-08-16 21:44:43 -03:00
David Bremner
1307868f1e cli/new: improve error reporting
Recently a user reported a crash in notmuch new, but because of
missing error reporting, all they could say was "A Xapian exception
occured". This commit adds the extra information available about
the error message in the exception.
2017-08-16 21:38:54 -03:00
David Bremner
d7b5db32c3 debian: start changelog for next debian upload 2017-08-16 21:38:26 -03:00
Daniel Kahn Gillmor
34e5d4d31a do not use bullets in debian/NEWS
see lintian's debian-news-entry-uses-asterisk for justification
2017-08-16 21:36:06 -03:00
Daniel Kahn Gillmor
56f2f362e1 remove obsolete lintian-override (see https://bugs.debian.org/865055) 2017-08-16 21:34:36 -03:00
David Bremner
84ae74aada uploaded to unstable
-----BEGIN PGP SIGNATURE-----
 
 iQGzBAABCAAdFiEE3VS2dnyDRXKVCQCp8gKXHaSnniwFAlmS3LAACgkQ8gKXHaSn
 niyTLgv8DZnqoy2Pv0ulDXZTFD9ruPXL2yDI3CJVdDJ6Mc6ku1M/W3fL8DLOmbpo
 mQE6hBTwnx2BbPqbt7yiz0Bidb//YqY/ow2oRbrMb0SxdXZKFcekXiwLiXiO9sXW
 Y1L2bl1hMDEVOYlndDYS5okJHx6AKpLTVUCdXFALl0AD748yHQlSeBXnpA6pNEVr
 TlQrvts14CPMjmyf+OSf1GeWEOObxf5j1iKouEB2IwyqQ08MPuOey7sqtO0jrPHi
 ev4CiV/hveem5Odlh5w1+CF5BTvsW1vbfdSyZ+krjvSk5oBSZrSYHD+y/k1mWBH6
 FCmi5/EYa674r8N12lA+ME7ExHMk40UeBC1+1uba9viR1YfKSkcZTjZnRRf2HvL4
 IxyEr1LUTOnLAlRMYK4huC1vsR4u9WESGppJ1az5yEQwSTIj4uXXi3OmU4c9oLEW
 +WcjqkNFQ6pfaqvjL/nIvvlWqAVhap34thlFOIo0z6850atm+ICGh3NyBl8D798W
 mFG7+NNm
 =vAlG
 -----END PGP SIGNATURE-----

Merge tag 'debian/0.25-6'

uploaded to unstable
2017-08-15 08:38:10 -03:00
David Bremner
6354745dcd debian: actually stop shipping 50notmuch.el 2017-08-15 07:52:47 -03:00
David Bremner
178d62cf9c uploaded to unstable
-----BEGIN PGP SIGNATURE-----
 
 iQGzBAABCAAdFiEE3VS2dnyDRXKVCQCp8gKXHaSnniwFAlmMPCwACgkQ8gKXHaSn
 nixThAwAgKxHKZDmg1C99HeDxXtyTYdAxcZaRg9+vceiaaeXksmrEM33Ywz9Cl0A
 g6Ozg+QKhn+ZfNMwjZ9gGzejjIqUY0My9Bw0xOniaXkj3oOuIWGQNJ3rgZdV9hGP
 TQ6QRhjllQjqlkbFWJSkj4NruaZPTBTKh6P3W5PsK7AqC4kKP5BijZHi9/b6CCDY
 fOs06fGMgGKGA5J82aBbNLRUN3qmGH4eL4e+ppAyPMlzTxxuXqTMgiGXlaGNJuBt
 Kmgj7ZI/3zWTNhe0rgIR1vMzTwevgCSHgSf/yiGeM5GQDOJ4PnSZjS7LZar682Qf
 nWjknJZXGg7ZB5mvmjlpfv6aDQ5zIwRMnZ9whWXGmKVjalWJolbGf/JYVKHs+QU1
 STx+WalcAjvAaix+Pe5T4k005zn8mwIVxKesJ1An5b2/tdWp0m8dhOacFl1bbpcN
 9RTAO+PWmKnpl9O1C+BIfTW1rNv1IsdGWhX7Ukmt3RG0kigwkU8FjoXKhxNCKzTm
 S20sDqXk
 =TJlv
 -----END PGP SIGNATURE-----

Merge tag 'debian/0.25-5'

uploaded to unstable
2017-08-10 07:08:49 -04:00
David Bremner
68dc19659a debian upload 0.25-5
fix typo in -4
2017-08-10 06:44:07 -04:00
David Bremner
0967e46475 test: add broken tests for maildir syncing
Users should be able to specify synced tags in new.tags
2017-08-06 15:40:28 -04:00
David Bremner
aa2abd2958 uploaded to unstable
-----BEGIN PGP SIGNATURE-----
 
 iQGzBAABCAAdFiEE3VS2dnyDRXKVCQCp8gKXHaSnniwFAlmE+IIACgkQ8gKXHaSn
 nizz2Qv/VClaGkXw48oJ8CIx/eKgSdYSQs8S2YjtRA/wcQzC5ORUa531hJnMCyiE
 nEJk6y9YJnkArr/lO7bwllBwtmcxjPqXW1V6O4+Zz6Fv2OHm4ZJwcfNgmJlaQzWt
 d4WpdFuA/wXqkcl23rJGNW6VyXc/jG11FoSmhge5ldco2AVvfDyzmjvA8C3wSc0l
 DJsPrzIwnrjvuGaHizoyEenFRTuaQpD76105xW3qiKzXCWg6UTMpxp7G4nNq2OkK
 hD9pv+IUJe2JuLbHAtgfXmZpJaicMNY31YlkQi5hrzVlWxE/ia0CckSxQcf7qYb6
 SCLBogOT1Q7Ik566FdEA6KIRs9bcePluxyNQ9ukFTMfasVtnibX7tVY4T9LWyh3r
 GeBk0nSOPMHc6j4KjIt6YI8p5K1HFWHhTN5ZU/NgnvBFOhHYmc5tqCOAGzX886yb
 pHYPQHRMGdJGMHIb3utnCXDrp0JWlD5vPihFTDfiRxUMokCh5DUpCHaxaCHCqpr7
 4sdsXakb
 =2fD2
 -----END PGP SIGNATURE-----

Merge tag 'debian/0.25-4'

uploaded to unstable
2017-08-04 18:43:33 -04:00
David Bremner
cdfeeda5e4 debian: upload 0.25-4
replace notmuch-emacs with elpa-emacs as a recommend
2017-08-04 18:15:09 -04:00
David Bremner
65b17dab46 uploaded to unstable
-----BEGIN PGP SIGNATURE-----
 
 iQGzBAABCAAdFiEE3VS2dnyDRXKVCQCp8gKXHaSnniwFAlmDOgMACgkQ8gKXHaSn
 niyZewwAjss63G1DccKBCQRY9FQ/QltrriBRKzzSCjUBUECXvMPuYDlVbrFXxRrS
 bgbAX2rxb+hujJkprJ4+FVDAsiP3WKhwuAcXvQsp7JFn68V1Gu8C9lidzKYeqKQI
 ZpAYYw0/h4Sy+5n72W2vmot5Xb5/8dQ9ktmh/UHNCXk4AbrpHtQPm9j03M/yQZj/
 tSs6+Z23hQf7DjQYmoSG27rdKFXtpIMDoiQiezxoI2VRob6ZmFtebXHLUAQ3H8Pj
 fasJcxywey39y3LlFMAzih2+zdb1Hvh0V5rgyX6Ww2OZJlevHfputjGWZz+cRTgZ
 wDefnv9fxQbqObiy4RWX1oJ5jCKq/onV40h/8x6fJSHIjMmoy8Lz5DNgqzlZ4q3x
 ZsGkFmaNrkxRFpfsPh9KnckjdshAsYuj7DlSqpA9Zq7+iLcfqR+5pPg4V4pfE0vV
 ANAbdprp0qMA0hCVpmW9t3jp8jvgX0UJJqAWVtOTKjIPM4JCDip26Dwz4sq0z9zD
 souH4rlk
 =xFSs
 -----END PGP SIGNATURE-----

Merge tag 'debian/0.25-3'

uploaded to unstable
2017-08-03 10:59:32 -04:00
David Bremner
479b14570b debian: changelog stanza for 0.25-3 2017-08-03 10:43:28 -04:00
David Bremner
0187785414 debian: add maintainer scripts to remove old startup file
We do it for notmuch and notmuch-emacs because the history is a bit
unclear. It seems to be safe to call when that conffile is not owned
by a given package
2017-08-03 10:42:54 -04:00
Daniel Kahn Gillmor
e5beec39d6 add "notmuch reindex" subcommand
This new subcommand takes a set of search terms, and re-indexes the
list of matching messages.
2017-08-01 21:17:47 -04:00
Daniel Kahn Gillmor
5b93fa6e70 lib: add notmuch_message_reindex
This new function asks the database to reindex a given message.
The parameter `indexopts` is currently ignored, but is intended to
provide an extensible API to support e.g. changing the encryption or
filtering status (e.g. whether and how certain non-plaintext parts are
indexed).
2017-08-01 21:17:47 -04:00
David Bremner
34d7753992 lib: add _notmuch_message_remove_indexed_terms
Testing will be provided via use in notmuch_message_reindex
2017-08-01 21:17:47 -04:00
David Bremner
ed4a9082c0 cli/search: print total number of files matched in summary output.
The structured output formats already have all of the filenames. This
is an easy bit of UI change to make the multiple files visible.
2017-08-01 21:17:47 -04:00
David Bremner
50340bcb78 lib: add notmuch_thread_get_total_files
This is relatively inexpensive in terms of run time and implementation
cost as we are already traversing the list of messages in a thread.
2017-08-01 21:17:47 -04:00
David Bremner
8a8e2b11c2 lib: add notmuch_message_count_files
This operation is relatively inexpensive, as the needed metadata is
already computed by our lazy metadata fetching. The goal is to support
better UI for messages with multipile files.
2017-08-01 21:17:47 -04:00
David Bremner
411675a6ce lib: index message files with duplicate message-ids
The corresponding xapian document just gets more terms added to it,
but this doesn't seem to break anything. Values on the other hand get
overwritten, which is a bit annoying, but arguably it is not worse to
take the values (from, subject, date) from the last file indexed
rather than the first.
2017-08-01 21:17:47 -04:00
David Bremner
639aced9c9 test: add known broken tests for duplicate message id
There are many other problems that could be tested, but these ones we
have some hope of fixing because it doesn't require UI changes, just
indexing changes.
2017-08-01 21:17:47 -04:00
David Bremner
4fdabd636e lib: refactor notmuch_database_add_message header parsing
This function is large and hard to understand and modify. Start to
break it down into meaningful pieces.
2017-08-01 21:17:47 -04:00
David Bremner
2f94b3090c lib: factor out message-id parsing to separate file.
This is really pure C string parsing, and doesn't need to be mixed in
with the Xapian/C++ layer. Although not strictly necessary, it also
makes it a bit more natural to call _parse_message_id from multiple
compilation units.
2017-08-01 21:17:47 -04:00
David Bremner
95b52e85b2 lib/n_d_add_message: refactor test for new/ghost messages
The switch is easier to understand than the side effects in the if
test. It also potentially allows us more flexibility in breaking up
this function into smaller pieces, since passing private_status around
is icky.
2017-08-01 21:17:47 -04:00
David Bremner
4034a7cec7 lib: isolate n_d_add_message and helper functions into own file
'database.cc' is becoming a monster, and it's hard to follow what the
various static functions are used for. It turns out that about 1/3 of
this file notmuch_database_add_message and helper functions not used
by any other function. This commit isolates this code into it's own
file.

Some side effects of this refactoring:

- find_doc_ids becomes the non-static (but still private)
  _notmuch_database_find_doc_ids
- a few instances of 'string' have 'std::' prepended, avoiding the
  need for 'using namespace std;' in the new file.
2017-08-01 21:17:47 -04:00
David Bremner
4a101ec7aa uploaded to unstable
-----BEGIN PGP SIGNATURE-----
 
 iQGzBAABCAAdFiEE3VS2dnyDRXKVCQCp8gKXHaSnniwFAll8dtIACgkQ8gKXHaSn
 niyGdgv/X3qLR8QVEZvgO9te9J01GBoSl+zhfrQ0Df1jJxzoQ+VhEkko1Manico/
 rmz+I2pVXJ2ESbdphka82kBLaThiRUqYE19/FoZG8CWVwp9bX28xas04Bn7a1tvi
 K2MYsPB4HMN6QJlrXw+Vb1dYW4RN+SOOZydQOqKBlk0qnyPC45/60p9K6PFgKpSO
 1nLjVOtn1DEpDv0iHJcr4oBMeJiktGv7zsyVVPXPZahaq+QIw0Cb8B7XUsO4MTdt
 heBJxf60zshYqwwPLNuxM4ncuXHRyJ0eDWG6aLVWTjJ/A0Tr19ro4RdEG9vK0any
 RmexCw8sYMFU8DGlLlnhU9Xxf4+PR3CPhrTgJ/W4zvfF4h8NYkzPo0u+6JFeRkke
 jeJsVw0erRL55B86hR6Zja5ybLlK3nysnZ+uXMgf5TKsy3vxbLO5H/mpnsVCh9Fc
 M2Mqza1kSIwXdsdVlgUyGW3lHkgw9Sx29cw2ToIViW6saVqJmTUvHhWgXifEAKAp
 NVvsWSpF
 =5/pe
 -----END PGP SIGNATURE-----

Merge tag 'debian/0.25-2'

uploaded to unstable
2017-07-29 07:52:28 -04:00
David Bremner
81125aca51 debian: update gmime dependencies
- build against gmime 3.0 by preference
- drop gmime-2.4-dev, no longer supported upstream
2017-07-26 11:00:31 -04:00
David Bremner
d663706055 notmuch Debian 0.25-1 upload (same as 0.25)
-----BEGIN PGP SIGNATURE-----
 
 iQGzBAABCAAdFiEE3VS2dnyDRXKVCQCp8gKXHaSnniwFAll3LdcACgkQ8gKXHaSn
 nixo1wv+L6bUHhe8GSvoTgAShG/ZCHh0CKk/yVxJAviHdJL5Tc5/xV5Cb2dwCvMy
 mKLV6vbQM6O+ibeqQuq1zrRDeEjgsQmf3w33xV8CTml+upk9T7ZoelekDvfPQbtw
 fG4cKTpEwiXZjy9r/p/O8t6jWaBcgtm3zrQhp/QReleAqYEOpSRkQFyLEVNamPAA
 OMIYx3becBRVFkuR+ok455JndE8aTTde2v+E6H+hJmuNsfIa2nC1DCODDUHkGitc
 T9JwZznKUuK9G5SYVSWbJ/CKbgQ4RbccYyuQV0IDtbZUcaQ3iM10kL3pUOnL51Bo
 Q9xNOk0JoskIrS5Eku5bXohyHitrqUwsHwYFhbn+zgtrvPsWPrAcY6h0wAe9nmY1
 zG1quiq/zDEPxS+wjkYIjkj1gpDuN/BhxksSlyLRHKKosiaqASCamzMFOAYFABIx
 z73JfLn13M2dp/Jyw50nqZe+ne+uKJUDhz7zUSXB1h0QBFJjqvtj7Q3FhXql/TnS
 +zUrOvmB
 =OAE9
 -----END PGP SIGNATURE-----

Merge tag 'debian/0.25-1'

notmuch Debian 0.25-1 upload (same as 0.25)
2017-07-26 10:02:16 -04:00
David Bremner
9f648dfbb8 debian: add changelog entry for 0.25 2017-07-25 07:30:24 -04:00
David Bremner
409f768c91 NEWS: set date 2017-07-25 07:24:11 -04:00
David Bremner
7a4c60e446 version: bump to 0.25 2017-07-25 07:21:29 -04:00
David Bremner
3cb823628c NEWS: formatting fixups
These are from Tomi, split from the previous commit
2017-07-25 07:16:20 -04:00
Tomi Ollila
d25f3603e8 NEWS for release 0.25: Emacs: support for stashing message timestamp 2017-07-25 07:15:45 -04:00
David Bremner
c28ac94abf emacs: Add commentary for MELPA users
We have a steady trickle of people using notmuch-emacs from melpa with
distro packages of notmuch, and then being confused when it doesn't
work. Try to warn people what a foot-gun this is; this commentary
should be copied to the melpa web site.
2017-07-20 07:01:17 -03:00
David Bremner
d95ccfe979 debian: changelog for 0.25~rc1-2 2017-07-18 19:48:12 -03:00
David Bremner
2a0b123ea6 debian: finalize changelog for 0.25~rc1-1 2017-07-18 07:12:12 -03:00
David Bremner
b8ccfe342d version: bump to 0.25~rc1 2017-07-18 07:04:29 -03:00
David Bremner
33e7441fb8 debian: allow emacs25 as a build depend
It's a bit crazy to require emacs 24 installed just to build, when it
isn't required to run.
2017-07-18 06:57:39 -03:00
David Bremner
1d82110f83 emacs: convert remaining format-versions from 3 to 4
This is needed for consistent beheviour between notmuch built against
gmime-2.6 and gmime-3.0 w.r.t. error reporting.
2017-07-18 06:57:26 -03:00
Daniel Kahn Gillmor
d55fffffd7 fix the generated documentation output 2017-07-18 06:53:57 -03:00
Daniel Kahn Gillmor
87bdfbc91f Fix orthography 2017-07-18 06:50:44 -03:00
Daniel Kahn Gillmor
f0b91832c2 use modern debian/copyright 2017-07-18 06:46:02 -03:00