David Bremner
6967dcbb02
lib/open: free GKeyFile
...
This fixes a small-to-medium (depending on size of config file) memory
leak.
2021-03-13 09:02:36 -04:00
David Bremner
6d5deb76ca
lib/open: free value from g_key_file_get_value
...
This fixes a small memory leak.
2021-03-13 08:58:21 -04:00
David Bremner
12301392d4
lib/open: use local talloc context in n_d_create_with_config
...
This better matches the memory allocation semantics in
notmuch_database_open_with_config.
2021-03-13 08:49:49 -04:00
uncrustify
8aeba1228a
lib: run uncrustify
...
This is the result of running
$ uncrustify --replace --config ../devel/uncrustify.cfg *.c *.h *.cc
in the lib directory
2021-03-13 08:45:34 -04:00
David Bremner
439d1ef814
lib/open: remove incorrect unused attribute
...
With the current unused macro in lib/notmuch-private.h this seems
harmless, but is misleading, since the parameter is in fact used.
2021-02-14 22:27:51 -04:00
David Bremner
0345bc57a0
lib/open: set HOOK_DIR on open
...
This is a simple two step path search. Most error checking is
deferred until running the hooks.
2021-02-06 19:56:13 -04:00
David Bremner
ac67cd84ee
lib: introduce notmuch_database_create_with_config
...
This takes a config path parameter, and can use that to decide the
new database location.
2021-02-06 19:48:34 -04:00
David Bremner
c447fe92c7
lib/database: move n_d_create* to open.cc
...
This will help share code with n_d_open_with_config.
2021-02-06 19:45:04 -04:00
David Bremner
eea258c0c9
lib: add NOTMUCH_STATUS_NO_CONFIG
...
This will allow client code to provide more meaningful diagnostics. In
particular it will enable "notmuch new" to continue suggsting the user
run "notmuch setup" to create a config after "notmuch new" is
transitioned to the new configuration framework.
2021-02-06 19:43:11 -04:00
David Bremner
1f860a6c41
lib/open: factor out choosing database path
...
The plan is to share code with a new database creation function that
has a similar API to n_d_open_with_config.
2021-02-06 19:41:28 -04:00
David Bremner
06a64cf0aa
lib/open: load default values for known configuration keys.
...
This emulates the behaviour of notmuch_config_open defined in the CLI,
in that it fills in default values if they are not otherwise defined.
2021-02-06 19:03:36 -04:00
David Bremner
39580e2d7f
lib/open: add support for config profiles and default locations
...
Fill in the remainder of the documented functionality for
n_d_open_with_config with respect to config file location. Similar
searching default locations of the database file still needs to be
added.
2021-02-06 18:59:00 -04:00
David Bremner
e5f3c3ed50
lib: add stub for notmuch_database_open_with_config
...
Initially document the intended API and copy the code from
notmuch_database_open_verbose. Most of the documented functionality is
not there yet.
2021-02-06 18:57:35 -04:00
David Bremner
4743e87c2c
lib: cache configuration information from database
...
The main goal is to allow configuration information to be temporarily
overridden by a separate config file. That will require further
changes not in this commit.
The performance impact is unclear, and will depend on the balance
between number of queries and number of distinct metadata items read
on the first call to n_d_get_config.
2021-02-06 18:56:05 -04:00
David Bremner
22d9094300
lib: factor out notmuch_database_open* related code to own file
...
Reduce the size of database.cc, and prepare for extending the database
opening API
2020-12-23 09:25:01 -04:00
