debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-12-24 18:34:52 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
5970 commits 14 branches 412 tags 12 MiB
Commit graph

5970 commits

This branch
This branch
All branches
Author SHA1 Message Date
David Bremner
439c5896b6 lib: refactor _notmuch_messsage_file_get_combined_header 
We need to rewrite the loop for gmime-3.0; move the loop body to its
own function to avoid code duplication.  Keep the common exit via
"goto DONE" to make this pure code movement.  It's important to note
that the existing exit path only deallocates the iterator.
 2017-07-14 21:23:52 -03:00
David Bremner
c040464a7c lib: wrap use of g_mime_utils_header_decode_date 
This changes return type in gmime 3.0
 2017-07-14 21:23:52 -03:00
David Bremner
fd6e4a9953 cli: hide rename of GMimeCertificateTrust 
Both the enum and the values are renamed in GMime 3.0.
 2017-07-14 21:23:52 -03:00
David Bremner
c7b9bdb81e cli: generalize use of GMIME_SIGNATURE_{ERROR,STATUS} to gmime-3 
The ERROR enum is merged into to the STATUS enum, and the set of flags
is different.
 2017-07-14 21:23:52 -03:00
David Bremner
f4a989484f util: fake gmime-2.6 compatible API for gmime-3.0 
Several functions have added arguments which accept NULL and provide
hopefully sensible defaults. Use macros to minimize source changes.
 2017-07-14 17:58:09 -03:00
David Bremner
32819f74d3 cli: replace use of g_mime_message_get_recipients 
This function, and associated enum, have been renamed and generalized
in gmime-3.0.
 2017-07-14 17:58:09 -03:00
David Bremner
cbb2d5608e lib/cli: replace use of g_mime_message_get_sender 
This function changes semantics in gmime-3.0 so make a new function
that provides the same functionality in both
 2017-07-14 17:58:09 -03:00
David Bremner
d7fea36916 cli: replace use of g_mime_message_get_reply_to 
This function changes signature in gmime 3.0, so we provide two new
functions, one for each signature.
 2017-07-14 17:58:09 -03:00
David Bremner
67dbd24ece cli: replace use of g_mime_message_get_date_as_string 
This function goes away in gmime-3.0. Also, the memory management is
apparently error prone, witness the memory leak in notmuch-reply.
 2017-07-14 17:58:09 -03:00
David Bremner
a58c75fdf6 test/crypto: mark extra space in userid as a bug in gmime-2.6 
I can't see the space in the output of gpg -K --with-colons
 2017-07-14 17:58:09 -03:00
David Bremner
a32dd81a55 cli: add space separator for keyword, string, and int arguments 
Defer the complication of optional boolean arguments for later (never?).
 2017-07-12 17:46:29 -03:00
David Bremner
de9baa29dc cli: change api of parse_option 
The idea is to allow it (in a future commit) advance to the next argv
element to get a value
 2017-07-12 17:44:15 -03:00
David Bremner
15815d4e4c cli/show: convert keyword options to booleans 
There are two keyword options here that impliment boolean options. It
is simpler to use the built-in boolean argument handling, and also
more robust against divergence in parsing boolean and keyword arguments.
 2017-07-12 17:42:23 -03:00
Kyle Meyer
37d1fa5672 emacs: tree: drop repeated "of" from docstring 2017-07-10 21:58:30 -03:00
David Bremner
6a79229737 debian: drop notmuch-dbg 
notmuch-dbgsym should be auto generated now.
 2017-07-06 09:21:14 -03:00
David Bremner
87ca29b7a7 test/crypto: add test for corrupted signatures 
Have an empty list of signatures is not the nicest mechanism to signal
complete failure to verify, but it's the one we currently have.
 2017-07-05 07:36:20 -03:00
David Bremner
4f48ae4a5f test: add test for modified pgp/mime signed message 
This is a good thing to test in any case, but particularly as we hit
the dark corners of the gmime crypto API.
 2017-07-05 07:36:20 -03:00
David Bremner
71f04b9a67 test: mark test as broken in gmime 3.0 
Currently I'm not sure what the intent of this test is, so it's not
clear if the new answer is better or worse than the old one.
 2017-07-05 07:13:02 -03:00
David Bremner
f7dd69d4c6 test: mark inclusion of headers as broken in gmime-2.x 
The output of headers here reflects an underlying bug / quirk of
gmime-2.6.
 2017-07-05 07:12:20 -03:00
David Bremner
3805898e3e test/multipart: reorganize creation of multipart message 
We want to have the bodies of the multipart available in a file on
their own for planned modifications to tests.
 2017-07-05 07:12:08 -03:00
David Bremner
e1b7d32db0 cli: implement structured output version 4 
Since the error field is unused by the emacs front end, no changes are
needed other than bumping the format version number.

As it is, this is a bit overengineered, but it will reduce duplication
when we support gmime 3.0
 2017-07-04 08:32:44 -03:00
David Bremner
9eacd7d367 devel/schemata: describe version 4 
Replace numeric errors with human readable flags.  Not all sig_error
keys will necessarily be generated with a given version of gmime.

Drop status "none" as it's currrently unused and I don't know what
it's for.
 2017-07-04 08:32:37 -03:00
David Bremner
b6f87c3085 emacs: convert to use format-version 3 
Keeping the emacs interface running old format-versions makes it
impossible to test new format-versions or deprecate old ones.
 2017-07-04 08:32:28 -03:00
David Bremner
0aba694c11 Merge branch 'release' 2017-07-03 21:35:05 -03:00
David Bremner
1970981bf1 debian: upload 0.24.2-2 
Just a no-change rebuild.
 2017-07-02 12:49:06 -03:00
David Bremner
ab02265777 Merge branch 'debian' 
merge in changes from 0.23.7-3 debian upload
 2017-07-02 10:50:17 -03:00
David Bremner
6dd00d6486 lib/index: add simple html filter 
The filter just drops all (HTML) tags. As an enabling change, pass the
content type to the filter constructor so we can decide which scanner
to user.
 2017-07-01 12:32:27 -03:00
David Bremner
64f81f95a1 lib/index.cc: generalize filter state machine 
To match things more complicated than fixed strings, we need states
with multiple out arrows.
 2017-07-01 12:32:17 -03:00
David Bremner
4a085a5137 lib/index: separate state table definition from scanner. 
We want to reuse the scanner definition with a different table.  This
is mainly code movement, and making the state table part of the filter
struct/class.
 2017-07-01 12:32:03 -03:00
David Bremner
20c15bc820 lib/index: generalize name of indexing filter 
In followup commits we will generalize the functionality of this
filter to deal with other types of non-indexable content.
 2017-07-01 12:31:55 -03:00
Tom Hinton
d848d4040a Fix minor mistake where indentation width is ignored 2017-06-30 08:55:16 -03:00
Damien Cassou
3840b6b495 Add indentation to imenu in notmuch-show 2017-06-30 08:33:29 -03:00
Piotr Trojanek
c9deb32933 remove extra space in Emacs prompt 
Trivial: fix extra space in the "Insert failed" Emacs prompt message.
 2017-06-25 09:57:48 -03:00
Piotr Trojanek
85c8304058 fix wrong printf formatting of signed/unsigned integers 2017-06-25 09:39:35 -03:00
Piotr Trojanek
410b96080c remove ineffective assignments 
Detected by cppcheck.
 2017-06-25 09:38:22 -03:00
Piotr Trojanek
e9d73f90a6 fix leaks due to missing invocations of va_end 
As the Linux man page states: "Each invocation of va_start() must be
matched by a corresponding invocation of va_end() in the same
function." Detected by cppcheck.
 2017-06-25 09:35:23 -03:00
Piotr Trojanek
a17eb162ee minor whitespace cleanups 2017-06-25 09:32:08 -03:00
Damien Cassou
a83ab29930 Add Emacs' imenu support in notmuch-show and notmuch-search 
Emacs' major modes can facilitate navigation in their buffers by
supporting Imenu. In such major modes, launching Imenu (M-x imenu)
makes Emacs display a list of items (e.g., function definitions in a
code buffer). Selecting an item from this list moves point to this
item.

This patch adds Imenu support to both notmuch-show and notmuch-search
buffers:

* in notmuch-show, Imenu will present a list of all messages in the
  currently visible thread;

* in notmuch-search, Imenu will present a list of all messages in the
  search buffer.
 2017-06-14 07:49:08 -03:00
David Bremner
1ec634461e Merge branch 'release' 2017-06-01 07:54:38 -03:00
David Bremner
2e86a4da55 fixup! NEWS: news for 0.24.2 2017-06-01 07:32:10 -03:00
David Bremner
6773235ea3 debian: changelog for 0.24.2-1 2017-06-01 07:25:56 -03:00
David Bremner
b6494a8dd9 NEWS: news for 0.24.2 2017-06-01 07:19:46 -03:00
David Bremner
4fb08341a4 version: bump to 0.24.2 2017-06-01 07:13:00 -03:00
David Bremner
11fda0bf2f cli/dump: don't include tags when not asked for 
Add in the analogous test for tags that is given for properties a few
lines below.
 2017-06-01 07:07:32 -03:00
David Bremner
e68022416d test: add known broken test --include=properties 
Reported in [1], --include=properties currently implies
--include=tags, but it should not.

[1] id:87y3u8vjbo.fsf@tethera.net
 2017-06-01 07:03:06 -03:00
David Bremner
6ac3d8c27f test: define GMime version dependant breakage 
We have some tests where the gmime 3 behaviour seems like a bug fix,
others where it's less clear, so we allow both possibilities.
 2017-05-31 21:54:08 -03:00
David Bremner
6977316a5f configure: add optional support for gmime-3.0 
This is only the changes to make configure work; it won't compile with
gmime-3.0 yet.
 2017-05-31 21:52:15 -03:00
David Bremner
51cf6dbab2 test/thread-naming: remove excess escaping from sender address. 
This is another case where the behaviour of gmime-2.6 and gmime-3.0
seems to differ. It may be that we prefer the more lax parsing of the
previous version, but that should be tested separately.
 2017-05-30 09:02:51 -03:00
David Bremner
233092577c cli/reply: fix two memory leaks, document a third 
internet_address_list_to_string returns an allocated string, which
needs to be freed with g_free. g_free can handle a NULL argument, so
we follow the usage elsewhere of calling it unconditionally.

The third leak we leave as it would require restructuring of
add_recipients_from_message, and is fixed by later gmime-3.0 porting.
 2017-05-30 09:02:29 -03:00
David Bremner
e86fa3226c perf-test: add memory test for reply 
Looking at the code for notmuch-reply, there seems to be several gmime
related memory leaks. This test is supposed to help eliminate those.
 2017-05-30 09:02:17 -03:00