debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-12-22 17:34:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
6456 commits 14 branches 412 tags 12 MiB
Commit graph

6456 commits

This branch
This branch
All branches
Author SHA1 Message Date
Sean Whitton
f9fbd1ee3b emacs: notmuch-search: avoid wiping out buffer-local variables 2020-07-22 19:48:24 -03:00
David Bremner
765ca7bc08 lib: fix return value for n_m_reindex 
Also update the documentation for the behaviour of n_m_get_thread_id
that this fix relies on.
 2020-07-20 08:54:42 -03:00
David Bremner
a0c83e1fac test: add known broken test for n_m_reindex on closed db 
This is another case where the code should not call INTERNAL_ERROR.
 2020-07-20 08:54:42 -03:00
David Bremner
a2279c322e test: regression for retrieving closed db from message 
This is actually one of the few potentially useful things you can do
with a message belonging to a closed database, since in principle you
could re-open the database.
 2020-07-20 08:54:42 -03:00
David Bremner
1578e2af6a test: regression test for destroying message with closed db 
This should be fine because the message belongs to the
database (talloc context wise).
 2020-07-20 08:54:42 -03:00
David Bremner
9244f58860 test: regression tests of n_m_freeze and n_m_thaw on closed db 
Neither of these accesses the database, so should be safe. Add the
tests to catch any changes in exception throwing.
 2020-07-20 08:54:42 -03:00
David Bremner
a2b90dc084 lib: handle xapian exception in n_m_remove_all_tags 
At least the exception we already catch should be reported properly.
 2020-07-20 08:54:42 -03:00
David Bremner
a4ac9941a8 test: add broken test for n_m_remove_all_tags 
The Xapian exception is actually caught here, but the NULL return is
not dealt with properly.
 2020-07-20 08:54:42 -03:00
David Bremner
e32f66d0e3 test: add regression test for n_m_maildir_flags_to_tags 
This function currently catches at least the obvious Xapian exceptions
and we want to keep it that way.
 2020-07-20 08:54:42 -03:00
David Bremner
485c32b1f3 cli/new: replace newly deprecated n_m_has_maildir_flag 
Boolean return values have no out-of-band-values to signal errors. The
change here is that a (somewhat unlikely) fatal error after indexing
will now be caught.
 2020-07-20 08:54:42 -03:00
David Bremner
b7572ceb14 lib: add notmuch_message_has_maildir_flag_st 
Initially the new function is mainly tested indirectly via the
wrapper.
 2020-07-20 08:54:42 -03:00
David Bremner
b21f0fcb6a test: add regression test for notmuch_message_has_maildir_flag 
This passes the NULL return inside _ensure_maildir_flags does not
break anything. Probably this should be handled more explicitely.
 2020-07-20 08:45:15 -03:00
David Bremner
7aaf6cbe9a configure: replace multiple redirects with redirected block 
This belatedly implements Tomi's suggestion from

     id:m25zaukv6u.fsf@guru.guru-group.fi
 2020-07-18 11:54:54 -03:00
David Bremner
49d630d0f3 bindings/ruby: replacy use of deprecated notmuch_message_get_flag 
Depending on the flag, this actually can return an errror, so raise a
ruby exception if so.
 2020-07-18 11:03:29 -03:00
David Bremner
c8539d5e92 lib/thread: replace use of deprecated notmuch_message_get_flag 
This adds one more reason why _notmuch_thread_create might return
NULL, but those were not previously enumerated, so no promises are
broken.
 2020-07-18 11:03:29 -03:00
David Bremner
a4776faa9b lib/add-message: drop use of deprecated notmuch_message_get_flag. 
As a side effect, we revert the switch from notmuch_bool_t to bool
here. This is because those two types are not actually compatible when
passing by reference.
 2020-07-18 11:03:28 -03:00
David Bremner
ef27194a93 cli/show: replace deprecated notmuch_message_get_flag 
This can be seen as moving an abort out of the library, into the CLI
where we can both print to stderr and shut the process down without
ill effect.
 2020-07-18 11:03:28 -03:00
David Bremner
c76832a203 cli/search: replace deprecated notmuch_message_get_flag 
Our handling of errors is all or nothing here, but it's an improvement
on the status quo, and it avoids rippling internal API changes.
 2020-07-18 11:03:28 -03:00
David Bremner
2d04ed2631 lib: catch exceptions in n_m_get_flag, provide n_m_get_flag_st 
It's not very nice to return FALSE for an error, so provide
notmuch_message_get_flag_st as a migration path.

Bump LIBNOTMUCH_MINOR_VERSION because the API is extended.
 2020-07-18 09:52:27 -03:00
David Bremner
13116c5ced configure: make sure WITH_PYTHON_DOCS is initialized 
Thanks to pazz for reporting the problem.
 2020-07-16 15:59:45 -03:00
David Bremner
a05da45523 doc: add new python bindings to main documentation tree. 
A separate conf.py and doc directory (or will be needed if someone wants
to build the bindings docs separately from notmuch.
 2020-07-15 08:37:11 -03:00
David Bremner
0e03e2d45e doc: replace use of environment variables with a generated config 
It is getting unwieldy to pass configuration options on the
sphinx-build command line, and I anticipate further use of
conditionals.

As far as I could tell, execing a string is the idiomatic way to
emulate include in Python.
 2020-07-15 08:32:15 -03:00
David Bremner
78e9b3467d lib: use COERCE_STATUS in n_m_{add,remove}_tag 
Currently I don't know of a good way of testing this, but at least in
principle a Xapian exception in _notmuch_message_{add,remove}_term
would cause an abort in the library.
 2020-07-14 07:31:45 -03:00
David Bremner
aa8e3f4487 lib: catch Xapian exceptions in n_m_remove_tag 
The churn here is again mainly re-indentation.
 2020-07-14 07:31:45 -03:00
David Bremner
0fc769aa4f test: add broken test for n_m_remove_tag 
Exception will be caught in next commit.
 2020-07-14 07:31:45 -03:00
David Bremner
33dd5fdc69 lib: catch Xapian exceptions in n_m_add_tag 
This is mostly just (horizontal) code movement due to wrapping
everything in a try / catch.
 2020-07-14 07:31:45 -03:00
David Bremner
503c035077 test: add known broken test for n_m_add_tag with closed db 
Exception will be caught in next commit.
 2020-07-14 07:31:45 -03:00
David Bremner
96befd0dd0 lib: catch Xapian exceptions in n_m_count_files 
This will require some care for the caller to check the sign, and not
just add error returns into a running total.
 2020-07-14 07:31:37 -03:00
David Bremner
6dc62d8bea test: add known broken test for n_m_count_files 
This will be fixed in the next commit.
 2020-07-14 07:31:30 -03:00
David Bremner
00f1abfdf4 lib: catch Xapian exceptions in n_m_get_tags 
This allows the function to return an error value rather than
crashing.
 2020-07-14 07:12:52 -03:00
David Bremner
d284dc00da test: add known broken test for n_m_get_tags 
This will be fixed in the next commit.
 2020-07-14 07:12:52 -03:00
David Bremner
e404d8a51d lib: use LOG_XAPIAN_EXCEPTION in n_m_get_date 
This should not change functionality, but does slightly reduce code
duplication. Perhaps more importantly it allows consistent changes to
all of the similar exception handling in message.cc.
 2020-07-14 07:12:52 -03:00
David Bremner
6eaadb43ad lib: add regression test for n_m_get_date; clarify API 
This function catches Xapian exceptions. The test is intended to make
sure it stays that way.
 2020-07-14 07:12:52 -03:00
David Bremner
ef15946def test: add known broken for n_m_get_flag on closed db 
Exception caught in next commit. Note that FLAG_GHOST is the only one
that triggers the I/O code path.
 2020-07-13 07:19:22 -03:00
David Bremner
286161b703 lib: catch exceptions in n_m_get_filenames 
This is essentially copied from the change to notmuch_message_get_filename
 2020-07-13 07:19:22 -03:00
David Bremner
2c2ba7d6e2 test: add known broken test for n_m_get_filenames 
This will be fixed in the next commit
 2020-07-13 07:19:22 -03:00
David Bremner
a606cba32b lib/n_m_g_filename: catch Xapian exceptions, document NULL return 
This is the same machinery as applied for

     notmuch_message_get_{thread,message}_id
 2020-07-13 07:19:22 -03:00
David Bremner
46e8076281 lib: add known broken test for notmuch_message_get_filename 
This will be fixed in the next commit
 2020-07-13 07:19:22 -03:00
David Bremner
a962bd2bf8 lib/n_m_get_replies: doc return, initial regression test 
We need to to set a query and retrieve the threads to meaningfully
test this function.
 2020-07-13 07:19:22 -03:00
David Bremner
056794a60d test: add regression test for n_m_get_header 
This function already catches Xapian exceptions, and we want to make
sure it stays that way.
 2020-07-13 07:19:22 -03:00
David Bremner
9201c50204 lib/message: use LOG_XAPIAN_EXCEPTION in n_m_get_header 
This is just for consistency, and a small reduction in the amount of
boilerplate.
 2020-07-13 07:19:22 -03:00
David Bremner
cca551a736 test: drop use of assert in closed db tests 
Instead of printing the same static string for each test, can replace
the assert with something simpler (or at least easier to integrate
into the test suite).
 2020-07-13 07:19:22 -03:00
David Bremner
a280d2a1a1 test: remove unused backup_database calls 
Since these backups are never restored, they should be safe to remove.
 2020-07-13 07:19:22 -03:00
David Bremner
30e43c7c27 debian: drop ValueRangeProcessor symbols 
These are not used since b90d852
 2020-07-11 19:52:21 -03:00
David Bremner
ee897cab8b test: drop upgrade from v1 tests 
These are less crucial since we stopped generating new database
versions and relied primarily on features. They also rely on a
pre-generated v1 database which happens to be chert format. This
backend is not supported by Xapian 1.5.

Also drop the tool gen-testdb.sh, which is currently broken, due to
changes in the testing infrastructure.
 2020-07-11 17:20:09 -03:00
David Bremner
b90d852a2f lib: migrate from Xapian ValueRangeProcessor to RangeProcessor 
This will be mandatory as of Xapian 1.5.  The API is also more
consistent with the FieldProcessor API, which helps code re-use a bit.

Note that this switches to using the built-in Xapian support for
prefixes on ranges (i.e. deleted code at beginning of
ParseTimeRangeProcessor::operator(), added prefix to constructor).

Another side effect of the migration is that we are generating smaller
queries, using one OP_VALUE_RANGE instead of an AND of two OP_VALUE_*
queries.
 2020-07-11 17:20:09 -03:00
David Bremner
a1b7cc834b lib: migrate to post Xapian 1.3.4 compact support 
The old API was deprecated in Xapian 1.3.4 and (will be) removed in 1.5.0
 2020-07-11 17:20:09 -03:00
Jonas Witschel
a962842d9b doc: make gzipped man pages reproducible 
gzip includes the name of the uncompressed file and its modification
timestamp into the compressed archive. The latter makes it hard to
reproduce the generated files bit for bit at a later time, so omit this
information from the archive using the "--no-name" option. This is a
reproducibility best practice, see
https://wiki.debian.org/ReproducibleBuilds/TimestampsInGzipHeaders
 2020-07-11 13:57:17 -03:00
David Bremner
5fbb2c7929 Merge branch 'release' 2020-07-10 23:24:41 -03:00
David Bremner
b502e26563 NEWS: update date for release 2020-07-10 22:25:04 -03:00