From: David Howells Subject: Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and register them Date: Fri, 25 Jun 2010 22:46:38 +0100 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Lines: 13 Message-ID: <18628.1277502398@redhat.com> References: <20100625125306.7f9b1966@tlielax.poochiereds.net> <4C24A606.5040001@suse.de> <1277220214-3597-1-git-send-email-sjayaraman@suse.de> <9822.1277312573@redhat.com> <22697.1277470549@redhat.com> Cc: dhowells@redhat.com, Suresh Jayaraman , Steve French , linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, samba-technical@lists.samba.org To: Jeff Layton X-From: linux-kernel-owner@vger.kernel.org Fri Jun 25 23:47:07 2010 Return-path: Envelope-to: glk-linux-kernel-3@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OSGjo-0006q8-ME for glk-linux-kernel-3@lo.gmane.org; Fri, 25 Jun 2010 23:47:05 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932250Ab0FYVqv (ORCPT ); Fri, 25 Jun 2010 17:46:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55406 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932088Ab0FYVqs (ORCPT ); Fri, 25 Jun 2010 17:46:48 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5PLkhIG005974 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 25 Jun 2010 17:46:43 -0400 Received: from redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5PLkd77017768; Fri, 25 Jun 2010 17:46:40 -0400 In-Reply-To: <20100625125306.7f9b1966@tlielax.poochiereds.net> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Archived-At: Jeff Layton wrote: > Looks like it mostly uses the ctime. IMO, the mtime would be a better > choice since it changes less frequently, but I don't guess that it > matters very much. I'd've thought mtime changes more frequently since that's altered when data is written. ctime is changed when attributes are changed. Note that Ext4 appears to have a file creation time field in its inode (struct ext4_inode::i_crtime[_extra]). Can Samba be made to use that? David