From: Randy Dunlap Subject: Re: rfc: rewrite commit subject line for subsystem maintainer preference tool Date: Tue, 16 Nov 2010 12:21:02 -0800 Organization: YPO4 Lines: 34 Message-ID: <20101116122102.86e7e0b9.rdunlap@xenotime.net> References: <1289845830.16461.149.camel@Joe-Laptop> <20101115190738.GF3338@sirena.org.uk> <1289848458.16461.150.camel@Joe-Laptop> <20101115193407.GK12986@rakim.wolfsonmicro.main> <1289850773.16461.166.camel@Joe-Laptop> <20101116104921.GL12986@rakim.wolfsonmicro.main> <1289919077.28741.50.camel@Joe-Laptop> <20101116183707.179964dd@schatten.dmk.lab> <20101116181226.GB26239@rakim.wolfsonmicro.main> <20101116203522.65240b18@schatten.dmk.lab> <20101116195530.GA7523@rakim.wolfsonmicro.main> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Jiri Kosina , linux-kernel@vger.kernel.org, Florian Mickler , Joe Perches , Andrew Morton To: Mark Brown X-From: alsa-devel-bounces@alsa-project.org Tue Nov 16 21:21:20 2010 Return-path: Envelope-to: glad-alsa-devel-2@m.gmane.org Received: from alsa0.perex.cz ([212.20.107.51]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PIS1m-0001Kj-Rd for glad-alsa-devel-2@m.gmane.org; Tue, 16 Nov 2010 21:21:18 +0100 Received: by alsa0.perex.cz (Postfix, from userid 1000) id 2FC2024371; Tue, 16 Nov 2010 21:21:18 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=disabled version=3.2.4 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id ACBEB24368; Tue, 16 Nov 2010 21:21:16 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 6AFBB24369; Tue, 16 Nov 2010 21:21:15 +0100 (CET) Received: from xenotime.net (xenotime.net [72.52.115.56]) by alsa0.perex.cz (Postfix) with SMTP id 6FDFD24363 for ; Tue, 16 Nov 2010 21:21:14 +0100 (CET) Received: from chimera.site ([173.50.240.230]) by xenotime.net for ; Tue, 16 Nov 2010 12:21:06 -0800 In-Reply-To: <20101116195530.GA7523@rakim.wolfsonmicro.main> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org Archived-At: On Tue, 16 Nov 2010 19:55:31 +0000 Mark Brown wrote: > On Tue, Nov 16, 2010 at 08:35:22PM +0100, Florian Mickler wrote: > > > Hehe, I know that I wouldn't want to hand edit every autogenerated patch > > people throw at me... What about just dropping everything before the > > last "]" or ":" and putting an autogenerated prefix before it in a > > pre-commit hook on your side? > > > That should work most of the time... don't know... maybe other > > It's the most of the time bit that worries me, I'm generally reluctant > to script things like this when the scripts aren't very widely used and > it's a pain to get hooks distributed over all my systems and working for > all the things I need to apply patches for. > > From my point of view my current approach is actually working pretty > well with most submitters, even people doing similar janitorial stuff. I don't know what you asked Joe to change, but asking someone to use the documented canonical patch format: The canonical patch subject line is: Subject: [PATCH 001/123] subsystem: summary phrase should be fine. And there is no need for printf-ish templates for this in MAINTAINERS either. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***