From: Jeff Layton <jlayton@samba.org>
Subject: Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and
	register them
Date: Fri, 25 Jun 2010 18:26:51 -0400
Lines: 30
Message-ID: <20100625182651.36800d06@tlielax.poochiereds.net>
References: <20100625125306.7f9b1966@tlielax.poochiereds.net>
	<4C24A606.5040001@suse.de>
	<1277220214-3597-1-git-send-email-sjayaraman@suse.de> <yes>
	<9822.1277312573@redhat.com> <22697.1277470549@redhat.com>
	<18628.1277502398@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
	linux-kernel@vger.kernel.org, Steve French <smfrench@gmail.com>,
	linux-fsdevel@vger.kernel.org
To: David Howells <dhowells@redhat.com>
X-From: samba-technical-bounces@lists.samba.org Sat Jun 26 00:27:01 2010
Return-path: <samba-technical-bounces@lists.samba.org>
Envelope-to: gnsi-samba-technical@m.gmane.org
Received: from fn.samba.org ([216.83.154.106] helo=lists.samba.org)
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <samba-technical-bounces@lists.samba.org>)
	id 1OSHMS-0003Yl-G8
	for gnsi-samba-technical@m.gmane.org; Sat, 26 Jun 2010 00:27:01 +0200
Received: from fn.samba.org (localhost [127.0.0.1])
	by lists.samba.org (Postfix) with ESMTP id 8919DAD2B8;
	Fri, 25 Jun 2010 16:26:57 -0600 (MDT)
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on fn.samba.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.7 required=3.8 tests=AWL,BAYES_00,SPF_NEUTRAL
	autolearn=no version=3.2.5
X-Original-To: samba-technical@lists.samba.org
Delivered-To: samba-technical@lists.samba.org
Received: from cdptpa-omtalb.mail.rr.com (cdptpa-omtalb.mail.rr.com
	[75.180.132.122])
	by lists.samba.org (Postfix) with ESMTP id ECB66AD220
	for <samba-technical@lists.samba.org>;
	Fri, 25 Jun 2010 16:26:51 -0600 (MDT)
X-Authority-Analysis: v=1.0 c=1 a=iVNVO0OCT3kA:10 a=yQWWgrYGNuUA:10
	a=kj9zAlcOel0A:10 a=20KFwNOVAAAA:8 a=hGzw-44bAAAA:8
	a=AraS79FXNJ3kHilSTm4A:9 a=3STw0N-n4mJG0pydffwA:7
	a=0uwppTlTaQ5HiYOalIavAxwTlvEA:4 a=CjuIK1q_8ugA:10
	a=jEp0ucaQiEUA:10 a=dowx1zmaLagA:10
X-Cloudmark-Score: 0
X-Originating-IP: 71.70.153.3
Received: from [71.70.153.3] ([71.70.153.3:55553] helo=mail.poochiereds.net)
	by cdptpa-oedge01.mail.rr.com (envelope-from <jlayton@samba.org>)
	(ecelerity 2.2.2.39 r()) with ESMTP
	id 78/FA-24471-C2D252C4; Fri, 25 Jun 2010 22:26:53 +0000
Received: from tlielax.poochiereds.net (tlielax.poochiereds.net [192.168.1.3])
	by mail.poochiereds.net (Postfix) with ESMTPS id 68F07580FA;
	Fri, 25 Jun 2010 18:26:52 -0400 (EDT)
In-Reply-To: <18628.1277502398@redhat.com>
X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; x86_64-redhat-linux-gnu)
X-BeenThere: samba-technical@lists.samba.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Discussions on Samba internals. For general questions please
	subscribe to the list samba@samba.org"
	<samba-technical.lists.samba.org>
List-Unsubscribe: <https://lists.samba.org/mailman/options/samba-technical>,
	<mailto:samba-technical-request@lists.samba.org?subject=unsubscribe>
List-Archive: <http://lists.samba.org/pipermail/samba-technical>
List-Post: <mailto:samba-technical@lists.samba.org>
List-Help: <mailto:samba-technical-request@lists.samba.org?subject=help>
List-Subscribe: <https://lists.samba.org/mailman/listinfo/samba-technical>,
	<mailto:samba-technical-request@lists.samba.org?subject=subscribe>
Sender: samba-technical-bounces@lists.samba.org
Errors-To: samba-technical-bounces@lists.samba.org
Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1003148>

On Fri, 25 Jun 2010 22:46:38 +0100
David Howells <dhowells@redhat.com> wrote:

> Jeff Layton <jlayton@samba.org> wrote:
> 
> > Looks like it mostly uses the ctime. IMO, the mtime would be a better
> > choice since it changes less frequently, but I don't guess that it
> > matters very much.
> 
> I'd've thought mtime changes more frequently since that's altered when data is
> written.  ctime is changed when attributes are changed.
> 

IIUC, updating mtime for a write is also an attribute change, and that
affects ctime. According to the stat(2) manpage:

       The field st_ctime is changed by writing or by setting  inode  informa-
       tion (i.e., owner, group, link count, mode, etc.).

> Note that Ext4 appears to have a file creation time field in its inode
> (struct ext4_inode::i_crtime[_extra]).  Can Samba be made to use that?
> 

Is it exposed to userspace in any (standard) way? It would be handy to
have that. While we're wishing...it might also be nice to have a
standard way to get at the i_generation from userspace too.

-- 
Jeff Layton <jlayton@samba.org>