notmuch/test
Jani Nikula 4a6721970a cli: use designated initializers for opt desc
Several changes at once, just to not have to change the same lines
several times over:

- Use designated initializers to initialize opt desc arrays.

- Only initialize the needed fields.

- Remove arg_id (short options) as unused.

- Replace opt_type and output_var with several type safe output
  variables, where the output variable being non-NULL determines the
  type. Introduce checks to ensure only one is set. The downside is
  some waste of const space per argument; this could be saved by
  retaining opt_type and using a union, but that's still pretty
  verbose.

- Fix some variables due to the type safety. Mostly a good thing, but
  leads to some enums being changed to ints. This is pedantically
  correct, but somewhat annoying. We could also cast, but that defeats
  the purpose a bit.

- Terminate the opt desc arrays using {}.

The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.

Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
2017-10-04 22:00:42 -03:00
..
corpora test: add known broken test for indexing html 2017-04-20 06:59:40 -03:00
emacs-show.expected-output emacs: change default for notmuch-crypto-process-mime to t 2017-07-15 09:11:32 -03:00
emacs.expected-output emacs: change default for notmuch-crypto-process-mime to t 2017-07-15 09:11:32 -03:00
smime test: initial tests for S/MIME and notmuch-emacs 2016-01-29 17:45:46 -04:00
test-databases Use rooted paths in .gitignore files 2017-08-18 19:42:35 -03:00
test.expected-output test: print empty line at the beginning of test script, not at end 2013-12-09 23:25:41 +08:00
tree.expected-output emacs: change default for notmuch-crypto-process-mime to t 2017-07-15 09:11:32 -03:00
valgrind test: change "#!/bin/bash" to "#!/usr/bin/env bash" enhances portability 2011-05-27 14:03:28 -07:00
.gitignore Use rooted paths in .gitignore files 2017-08-18 19:42:35 -03:00
aggregate-results.sh test suite: don't consider skipped individual tests as failing 2015-09-25 09:18:22 -03:00
arg-test.c cli: use designated initializers for opt desc 2017-10-04 22:00:42 -03:00
atomicity.py test: atomicity.py: improve exit probability on failure 2017-03-10 08:21:28 -04:00
database-test.c Use https instead of http where possible 2016-06-05 08:32:17 -03:00
database-test.h test: add database routines for testing 2012-12-02 15:51:32 -04:00
emacs-address-cleaning.el emacs: More address cleaning. 2012-02-03 21:24:48 -04:00
gen-threads.py test: Make gen-threads work with python3 2014-11-02 19:43:39 +01:00
ghost-report.cc test: add test-binary to print the number of ghost messages 2016-04-15 07:07:23 -03:00
gnupg-secret-key.asc test: add crypto tests for signature verification and decryption 2011-05-27 16:22:00 -07:00
gnupg-secret-key.NOTE test: add crypto tests for signature verification and decryption 2011-05-27 16:22:00 -07:00
hex-xcode.c cli: use designated initializers for opt desc 2017-10-04 22:00:42 -03:00
make-db-version.cc test: Tool to build DB with specific version and features 2014-08-30 10:43:46 -07:00
Makefile fix sum moar typos [build scripts, Makefiles] 2011-06-23 15:44:59 -07:00
Makefile.local rename libutil.a to libnotmuch_util.a 2017-03-18 21:37:43 -03:00
notmuch-test test: Update extant references to corpus.mail 2017-08-18 19:42:19 -03:00
notmuch-test.h test: fix printf format 2016-09-22 08:11:42 -03:00
parse-time.c Use https instead of http where possible 2016-06-05 08:32:17 -03:00
random-corpus.c cli: use designated initializers for opt desc 2017-10-04 22:00:42 -03:00
README Fix orthography 2017-07-18 06:50:44 -03:00
smtp-dummy.c test/smtp-dummy: convert to 'goto DONE' style 2017-08-30 07:16:24 -03:00
symbol-test.cc test: check argc in symbol-test 2015-09-24 07:28:51 -03:00
T000-basic.sh test: remove remainder of previously killed basic test 2017-08-18 19:45:17 -03:00
T010-help-test.sh test: require test_begin_subtest before test_expect_success 2017-03-09 09:01:21 -04:00
T020-compact.sh test: require test_begin_subtest before test_expect_code 2017-03-09 09:03:40 -04:00
T030-config.sh config: deprecate/drop crypto.gpg_path under gmime 2.6/3.0 2017-07-14 21:23:52 -03:00
T040-setup.sh config: deprecate/drop crypto.gpg_path under gmime 2.6/3.0 2017-07-14 21:23:52 -03:00
T050-new.sh test: Fix T050-new.sh on some Travis CI machines 2017-08-30 07:24:44 -03:00
T060-count.sh lib: query make exclude handling non-destructive 2017-03-04 20:47:25 -04:00
T070-insert.sh database: add n_d_index_file (deprecates n_d_add_message) 2017-08-23 07:38:37 -03:00
T080-search.sh cli/search: print total number of files matched in summary output. 2017-08-01 21:17:47 -04:00
T090-search-output.sh test: standardize argument order to test_expect_equal_file 2017-04-06 14:37:02 -03:00
T095-address.sh test: standardize argument order to test_expect_equal_file 2017-04-06 14:37:02 -03:00
T100-search-by-folder.sh cli/search: print total number of files matched in summary output. 2017-08-01 21:17:47 -04:00
T110-search-position-overlap-bug.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T120-search-insufficient-from-quoting.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T130-search-limiting.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T140-excludes.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T150-tagging.sh test: require test_begin_subtest before test_expect_code 2017-03-09 09:03:40 -04:00
T160-json.sh lib: index message files with duplicate message-ids 2017-08-01 21:17:47 -04:00
T170-sexp.sh test: Perform T170 tests that don't require dtach before any that do. 2017-08-28 08:02:02 -03:00
T180-text.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T190-multipart.sh test: mark inclusion of headers as broken in gmime-2.x 2017-07-05 07:12:20 -03:00
T200-thread-naming.sh test/thread-naming: remove excess escaping from sender address. 2017-05-30 09:02:51 -03:00
T205-author-naming.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T210-raw.sh cli: tell how many messages were precisely matched when expected 1 match 2016-05-19 07:49:03 -03:00
T220-reply.sh Add additional munged reply-to tests 2017-07-14 21:23:52 -03:00
T230-reply-to-sender.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T240-dump-restore.sh test: standardize argument order to test_expect_equal_file 2017-04-06 14:37:02 -03:00
T250-uuencode.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T260-thread-order.sh test: replaced use of python with $NOTMUCH_PYTHON (twice) 2017-02-23 08:55:24 -04:00
T270-author-order.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T280-from-guessing.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T290-long-id.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T300-encoding.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T310-emacs.sh emacs: sanitize subject in replies 2017-09-27 08:15:02 -03:00
T320-emacs-large-search-buffer.sh test: standardize argument order to test_expect_equal_file 2017-04-06 14:37:02 -03:00
T330-emacs-subject-to-filename.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T340-maildir-sync.sh CLI/new: support maildir synced tags in new.tags 2017-08-29 21:57:38 -03:00
T350-crypto.sh lib: index the content-type of the parts of encrypted messages 2017-09-17 20:01:19 -03:00
T355-smime.sh cli: implement structured output version 4 2017-07-04 08:32:44 -03:00
T360-symbol-hiding.sh build: switch to hiding libnotmuch symbols by default 2017-05-12 07:17:18 -03:00
T370-search-folder-coherence.sh cli/search: print total number of files matched in summary output. 2017-08-01 21:17:47 -04:00
T380-atomicity.sh test: require test_begin_subtest before test_expect_success 2017-03-09 09:01:21 -04:00
T390-python.sh T390-python: add test for get_message_parts and special characters 2017-10-02 07:21:41 -03:00
T395-ruby.sh test: standardize argument order to test_expect_equal_file 2017-04-06 14:37:02 -03:00
T400-hooks.sh test: require test_begin_subtest before test_expect_code 2017-03-09 09:03:40 -04:00
T410-argument-parsing.sh test: standardize argument order to test_expect_equal_file 2017-04-06 14:37:02 -03:00
T420-emacs-test-functions.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T430-emacs-address-cleaning.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T440-emacs-hello.sh test: standardize argument order to test_expect_equal_file 2017-04-06 14:37:02 -03:00
T450-emacs-show.sh emacs: change default for notmuch-crypto-process-mime to t 2017-07-15 09:11:32 -03:00
T455-emacs-charsets.sh test: standardize argument order to test_expect_equal_file 2017-04-06 14:37:02 -03:00
T460-emacs-tree.sh test: remove debugging "output" 2017-04-06 14:37:11 -03:00
T470-missing-headers.sh cli/show: list all filenames of a message in the formatted output 2017-02-26 07:41:33 -04:00
T480-hex-escaping.sh test: standardize argument order to test_expect_equal_file 2017-04-06 14:37:02 -03:00
T490-parse-time-string.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T500-search-date.sh cli/search: print total number of files matched in summary output. 2017-08-01 21:17:47 -04:00
T510-thread-replies.sh cli/show: list all filenames of a message in the formatted output 2017-02-26 07:41:33 -04:00
T520-show.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T530-upgrade.sh test: require test_begin_subtest before test_expect_success 2017-03-09 09:01:21 -04:00
T550-db-features.sh test: make script exit (1) if it "fails" to source (.) a file 2015-08-07 21:56:39 +02:00
T560-lib-error.sh database: add n_d_index_file (deprecates n_d_add_message) 2017-08-23 07:38:37 -03:00
T570-revision-tracking.sh test: require test_begin_subtest before test_expect_code 2017-03-09 09:03:40 -04:00
T580-thread-search.sh test: wrap 'wc -l' results in arithmetic evaluation to strip whitespace 2017-01-27 22:02:36 -04:00
T590-libconfig.sh cli/dump: bump dump format version to 3 2017-04-01 09:10:15 -03:00
T590-thread-breakage.sh test: shrink T590-thread-breakage test decription to one line 2017-03-04 21:21:11 -04:00
T600-named-queries.sh test: require test_begin_subtest before test_expect_code 2017-03-09 09:03:40 -04:00
T610-message-property.sh cli/dump: don't include tags when not asked for 2017-06-01 07:07:32 -03:00
T620-lock.sh test: initial tests for locking retry 2016-06-29 09:05:28 +02:00
T630-emacs-draft.sh Test: fix draft test for emacs23 2016-11-14 18:01:36 -04:00
T640-database-modified.sh lib: replace deprecated n_q_search_messages with status returning version 2017-03-22 08:35:07 -03:00
T650-regexp-query.sh cli/search: print total number of files matched in summary output. 2017-08-01 21:17:47 -04:00
T660-bad-date.sh lib: clamp return value of g_mime_utils_header_decode_date to >=0 2017-03-15 21:58:25 -03:00
T670-duplicate-mid.sh test/duplicate-mid: check for subject with notmuch-show 2017-09-05 21:53:06 -03:00
T680-html-indexing.sh lib/index: add simple html filter 2017-07-01 12:32:27 -03:00
T690-command-line-args.sh cli: add space separator for keyword, string, and int arguments 2017-07-12 17:46:29 -03:00
T700-reindex.sh add "notmuch reindex" subcommand 2017-08-01 21:17:47 -04:00
test-lib-common.sh test: move generate_message, add_message into test-lib-common.sh 2017-08-20 08:34:03 -03:00
test-lib-FREEBSD.sh tests: add compatibility layer 2017-03-25 07:56:52 -03:00
test-lib.el emacs: maildir: add the actual insert code 2016-09-04 08:23:14 -03:00
test-lib.sh test: notmuch_drop_mail_headers() style update 2017-09-04 08:03:52 -03:00
test-verbose test: require test_begin_subtest before test_expect_success 2017-03-09 09:01:21 -04:00

Notmuch test suite
==================
This directory contains the test suite for notmuch.

When fixing bugs or enhancing notmuch, you are strongly encouraged to
add tests in this directory to cover what you are trying to fix or
enhance.

Prerequisites
-------------
The test system itself requires:

  - bash(1) version 4.0 or newer

Without bash 4.0+ the tests just refuse to run.

Some tests require external dependencies to run. Without them, they
will be skipped, or (rarely) marked failed. Please install these, so
that you know if you break anything.

  - GNU tar(1)
  - dtach(1)
  - emacs(1)
  - emacsclient(1)
  - gdb(1)
  - gpg(1)
  - python(1)

If your system lacks these tools or have older, non-upgradable versions
of these, please (possibly compile and) install these to some other
path, for example /usr/local/bin or /opt/gnu/bin. Then prepend the
chosen directory to your PATH before running the tests.

e.g. env PATH=/opt/gnu/bin:$PATH make test

For FreeBSD you need to install latest gdb from ports or packages and
provide path to it in TEST_GDB environment variable before executing
the tests, native FreeBSD gdb does not not work.  If you install
coreutils, which provides GNU versions of basic utils like 'date' and
'base64' on FreeBSD, the test suite will use these instead of the
native ones. This provides robustness against portability issues with
these system tools. Most often the tests are written, reviewed and
tested on Linux system so such portability issues arise from time to
time.


Running Tests
-------------
The easiest way to run tests is to say "make test", (or simply run the
notmuch-test script). Either command will run all available tests.

Alternately, you can run a specific subset of tests by simply invoking
one of the executable scripts in this directory, (such as ./T*-search.sh,
./T*-reply.sh, etc). Note that you will probably want "make test-binaries"
before running individual tests.

The following command-line options are available when running tests:

--debug::
	This may help the person who is developing a new test.
	It causes the command defined with test_debug to run.

--immediate::
	This causes the test to immediately exit upon the first
	failed test.

--valgrind::
	Execute notmuch with valgrind and exit with status
	126 on errors (just like regular tests, this will only stop
	the test script when running under -i).  Valgrind errors
	go to stderr, so you might want to pass the -v option, too.

	Since it makes no sense to run the tests with --valgrind and
	not see any output, this option implies --verbose.  For
	convenience, it also implies --tee.

--tee::
	In addition to printing the test output to the terminal,
	write it to files named 't/test-results/$TEST_NAME.out'.
	As the names depend on the tests' file names, it is safe to
	run the tests with this option in parallel.

--root=<dir>::
	This runs the testsuites specified under a separate directory.
	However, caution is advised, as not all tests are maintained
	with this relocation in mind, so some tests may behave
	differently.

	Pointing this argument at a tmpfs filesystem can improve the
	speed of the test suite for some users.

Certain tests require precomputed databases to complete. You can fetch these
databases with

	make download-test-databases

If you do not download the test databases, the relevant tests will be
skipped.

When invoking the test suite via "make test" any of the above options
can be specified as follows:

	make test OPTIONS="--verbose"

You can choose an emacs binary (and corresponding emacsclient) to run
the tests in one of the following ways.

	TEST_EMACS=my-emacs TEST_EMACSCLIENT=my-emacsclient make test
	TEST_EMACS=my-emacs TEST_EMACSCLIENT=my-emacsclient ./T*-emacs.sh
	make test TEST_EMACS=my-emacs TEST_EMACSCLIENT=my-emacsclient

Some tests may require a c compiler. You can choose the name and flags similarly
to with emacs, e.g.

     make test TEST_CC=gcc TEST_CFLAGS="-g -O2"

Quiet Execution
---------------

Normally, when new script starts and when test PASSes you get a message
printed on screen. This printing can be disabled by setting the
NOTMUCH_TEST_QUIET variable to a non-null value. Message on test
failures and skips are still printed.

Skipping Tests
--------------
If, for any reason, you need to skip one or more tests, you can do so
by setting the NOTMUCH_SKIP_TESTS variable to the name of one or more
sections of tests.

For example:

    $ NOTMUCH_SKIP_TESTS="search reply" make test

Even more fine-grained skipping is possible by appending a test number
(or glob pattern) after the section name. For example, the first
search test and the second reply test could be skipped with:

    $ NOTMUCH_SKIP_TESTS="search.1 reply.2" make test

Note that some tests in the existing test suite rely on previous test
items, so you cannot arbitrarily skip any test and expect the
remaining tests to be unaffected.

Currently we do not consider skipped tests as build failures. For
maximum robustness, when setting up automated build processes, you
should explicitly skip tests, rather than relying on notmuch's
detection of missing prerequisites. In the future we may treat tests
unable to run because of missing prerequisites, but not explicitly
skipped by the user, as failures.

Writing Tests
-------------
The test script is written as a shell script. It is to be named as
Tddd-testname.sh where 'ddd' is three digits and 'testname' the "bare"
name of your test. Tests will be run in order the 'ddd' part determines.

The test script should start with the standard "#!/usr/bin/env bash"
and an assignment to variable 'test_description', like this:

	#!/usr/bin/env bash

	test_description='xxx test (option --frotz)

	This test exercises the "notmuch xxx" command when
	given the option --frotz.'

Source 'test-lib.sh'
--------------------
After assigning test_description, the test script should source
test-lib.sh like this:

	. ./test-lib.sh || exit 1

This test harness library does the following things:

 - If the script is invoked with command line argument --help
   (or -h), it shows the test_description and exits.

 - Creates a temporary directory with default notmuch-config and a
   mail store with a corpus of mail, (initially, 50 early messages
   sent to the notmuch list). This directory is
   test/tmp.<test-basename>. The path to notmuch-config is exported in
   NOTMUCH_CONFIG environment variable and mail store path is stored
   in MAIL_DIR variable.

 - Defines standard test helper functions for your scripts to
   use.  These functions are designed to make all scripts behave
   consistently when command line arguments --verbose (or -v),
   --debug (or -d), and --immediate (or -i) is given.

End with test_done
------------------
Your script will be a sequence of tests, using helper functions
from the test harness library.  At the end of the script, call
'test_done'.

Test harness library
--------------------
There are a handful helper functions defined in the test harness
library for your script to use.

 test_begin_subtest <message>

   Set the test description message for a subsequent test_expect_*
   invocation (see below).

 test_expect_success <script>

   This takes a string as parameter, and evaluates the
   <script>.  If it yields success, test is considered
   successful.

 test_expect_code <code> <script>

   This takes two strings as parameter, and evaluates the <script>.
   If it yields <code> exit status, test is considered successful.

 test_subtest_known_broken

   Mark the current test as broken.  Such tests are expected to fail.
   Unlike the normal tests, which say "PASS" on success and "FAIL" on
   failure, these will say "FIXED" on success and "BROKEN" on failure.
   Failures from these tests won't cause -i (immediate) to stop.  A
   test must call this before any test_expect_* function.

 test_expect_equal <output> <expected>

   This is an often-used convenience function built on top of
   test_expect_success. It uses the message from the last
   test_begin_subtest call, so call before calling
   test_expect_equal. This function generates a successful test if
   both the <output> and <expected> strings are identical. If not, it
   will generate a failure and print the difference of the two
   strings.

 test_expect_equal_file <file1> <file2>

   Identical to test_expect_equal, except that <file1> and <file2>
   are files instead of strings.  This is a much more robust method to
   compare formatted textual information, since it also notices
   whitespace and closing newline differences.

 test_expect_equal_json <output> <expected>

   Identical to test_expect_equal, except that the two strings are
   treated as JSON and canonicalized before equality testing.  This is
   useful to abstract away from whitespace differences in the expected
   output and that generated by running a notmuch command.

 test_debug <script>

   This takes a single argument, <script>, and evaluates it only
   when the test script is started with --debug command line
   argument.  This is primarily meant for use during the
   development of a new test script.

 test_emacs <emacs-lisp-expressions>

   This function executes the provided emacs lisp script within
   emacs. The script can be a sequence of emacs lisp expressions,
   (that is, they will be evaluated within a progn form). Emacs
   stdout and stderr is not available, the common way to get output
   is to save it to a file. There are some auxiliary functions
   useful in emacs tests provided in test-lib.el. Do not use `setq'
   for setting variables in Emacs tests because it affects other
   tests that may run in the same Emacs instance.  Use `let' instead
   so the scope of the changed variables is limited to a single test.

 test_emacs_expect_t <emacs-lisp-expressions>

  This function executes the provided emacs lisp script within
  emacs in a manner similar to 'test_emacs'. The expressions should
  return the value `t' to indicate that the test has passed. If the
  test does not return `t' then it is considered failed and all data
  returned by the test is reported to the tester.

 test_done

   Your test script must have test_done at the end.  Its purpose
   is to summarize successes and failures in the test script and
   exit with an appropriate error code.

There are also a number of notmuch-specific auxiliary functions and
variables which are useful in writing tests:

  generate_message

    Generates a message with an optional template. Most tests will
    actually prefer to call add_message. See below.

  add_message

    Generate a message and add it to the database (by calling "notmuch
    new"). It is sufficient to simply call add_message with no
    arguments if you don't care about the content of the message. If
    more control is needed, arguments can be provide to specify many
    different header values for the new message. See the documentation
    within test-lib.sh or refer to many example calls within existing
    tests.

  add_email_corpus

    This function should be called at the beginning of a test file
    when a test needs to operate on a non-empty body of messages. It
    will initialize the mail database to a known state of 50 sample
    messages, (culled from the early history of the notmuch mailing
    list).

  notmuch_counter_reset
  $notmuch_counter_command
  notmuch_counter_value

    These allow to count how many times notmuch binary is called.
    notmuch_counter_reset() function generates a script that counts
    how many times it is called and resets the counter to zero.  The
    function sets $notmuch_counter_command variable to the path to the
    generated script that should be called instead of notmuch to do
    the counting.  The notmuch_counter_value() function prints the
    current counter value.

There are also functions which remove various environment-dependent
values from notmuch output; these are useful to ensure that test
results remain consistent across different machines.

 notmuch_search_sanitize
 notmuch_show_sanitize
 notmuch_show_sanitize_all
 notmuch_json_show_sanitize

   All these functions should receive the text to be sanitized as the
   input of a pipe, e.g.
   output=`notmuch search "..." | notmuch_search_sanitize`