notmuch/bindings/python/notmuch
Daniel Kahn Gillmor b10ce6bc23 database: add n_d_index_file (deprecates n_d_add_message)
We need a way to pass parameters to the indexing functionality on the
first index, not just on reindexing.  The obvious place is in
notmuch_database_add_message.  But since modifying the argument list
would break both API and ABI, we needed a new name.

I considered notmuch_database_add_message_with_params(), but the
functionality we're talking about doesn't always add a message.  It
tries to index a specific file, possibly adding a message, but
possibly doing other things, like adding terms to an existing message,
or failing to deal with message objects entirely (e.g. because the
file didn't contain a message).

So i chose the function name notmuch_database_index_file.

I confess i'm a little concerned about confusing future notmuch
developers with the new name, since we already have a private
_notmuch_message_index_file function, and the two do rather different
things.  But i think the added clarity for people linking against the
future libnotmuch and the capacity for using index parameters makes
this a worthwhile tradeoff.  (that said, if anyone has another name
that they strongly prefer, i'd be happy to go with it)

This changeset also adjusts the tests so that we test whether the new,
preferred function returns bad values (since the deprecated function
just calls the new one).

We can keep the deprecated n_d_add_message function around as long as
we like, but at the next place where we're forced to break API or ABI
we can probably choose to drop the name relatively safely.

NOTE: there is probably more cleanup to do in the ruby and go bindings
to complete the deprecation directly.  I don't know those languages
well enough to attempt a fix; i don't know how to test them; and i
don't know the culture around those languages about API additions or
deprecations.
2017-08-23 07:38:37 -03:00
..
__init__.py Use https instead of http where possible 2016-06-05 08:32:17 -03:00
compat.py Use https instead of http where possible 2016-06-05 08:32:17 -03:00
database.py database: add n_d_index_file (deprecates n_d_add_message) 2017-08-23 07:38:37 -03:00
directory.py database: add n_d_index_file (deprecates n_d_add_message) 2017-08-23 07:38:37 -03:00
errors.py Use https instead of http where possible 2016-06-05 08:32:17 -03:00
filenames.py Use https instead of http where possible 2016-06-05 08:32:17 -03:00
globals.py Use https instead of http where possible 2016-06-05 08:32:17 -03:00
message.py database: add n_d_index_file (deprecates n_d_add_message) 2017-08-23 07:38:37 -03:00
messages.py Use https instead of http where possible 2016-06-05 08:32:17 -03:00
query.py lib: replace deprecated n_q_count_threads with status returning version 2017-03-22 08:35:07 -03:00
tag.py Use https instead of http where possible 2016-06-05 08:32:17 -03:00
thread.py Fix orthography 2017-07-18 06:50:44 -03:00
threads.py Use https instead of http where possible 2016-06-05 08:32:17 -03:00
version.py version: bump to 0.25 2017-07-25 07:21:29 -04:00