mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-11-22 02:48:08 +01:00
4a6721970a
Several changes at once, just to not have to change the same lines
several times over:
- Use designated initializers to initialize opt desc arrays.
- Only initialize the needed fields.
- Remove arg_id (short options) as unused.
- Replace opt_type and output_var with several type safe output
variables, where the output variable being non-NULL determines the
type. Introduce checks to ensure only one is set. The downside is
some waste of const space per argument; this could be saved by
retaining opt_type and using a union, but that's still pretty
verbose.
- Fix some variables due to the type safety. Mostly a good thing, but
leads to some enums being changed to ints. This is pedantically
correct, but somewhat annoying. We could also cast, but that defeats
the purpose a bit.
- Terminate the opt desc arrays using {}.
The output variable type safety and the ability to add new fields for
just some output types or arguments are the big wins. For example, if
we wanted to add a variable to set when the argument is present, we
could do so for just the arguments that need it.
Beauty is in the eye of the beholder, but I think this looks nice when
defining the arguments, and reduces some of the verbosity we have
there.
73 lines
2.1 KiB
C
73 lines
2.1 KiB
C
/* notmuch - Not much of an email program, (just index and search)
|
|
*
|
|
* Copyright © 2013 Ben Gamari
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see https://www.gnu.org/licenses/ .
|
|
*
|
|
* Author: Ben Gamari <bgamari.foss@gmail.com>
|
|
*/
|
|
|
|
#include "notmuch-client.h"
|
|
|
|
static void
|
|
status_update_cb (const char *msg, unused (void *closure))
|
|
{
|
|
printf ("%s\n", msg);
|
|
}
|
|
|
|
int
|
|
notmuch_compact_command (notmuch_config_t *config, int argc, char *argv[])
|
|
{
|
|
const char *path = notmuch_config_get_database_path (config);
|
|
const char *backup_path = NULL;
|
|
notmuch_status_t ret;
|
|
notmuch_bool_t quiet = FALSE;
|
|
int opt_index;
|
|
|
|
notmuch_opt_desc_t options[] = {
|
|
{ .opt_string = &backup_path, .name = "backup" },
|
|
{ .opt_bool = &quiet, .name = "quiet" },
|
|
{ .opt_inherit = notmuch_shared_options },
|
|
{ }
|
|
};
|
|
|
|
opt_index = parse_arguments (argc, argv, options, 1);
|
|
if (opt_index < 0)
|
|
return EXIT_FAILURE;
|
|
|
|
if (notmuch_requested_db_uuid) {
|
|
fprintf (stderr, "Error: --uuid not implemented for compact\n");
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
notmuch_process_shared_options (argv[0]);
|
|
|
|
if (! quiet)
|
|
printf ("Compacting database...\n");
|
|
ret = notmuch_database_compact (path, backup_path,
|
|
quiet ? NULL : status_update_cb, NULL);
|
|
if (ret) {
|
|
fprintf (stderr, "Compaction failed: %s\n", notmuch_status_to_string (ret));
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
if (! quiet) {
|
|
if (backup_path)
|
|
printf ("The old database has been moved to %s.\n", backup_path);
|
|
|
|
printf ("Done.\n");
|
|
}
|
|
|
|
return EXIT_SUCCESS;
|
|
}
|