mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-11-25 04:18:08 +01:00
98845fdbb2
Previously we were using Xapian's add_document to allocate document ID values for notmuch_message_t objects. This had the drawback of adding a partially constructed mail document to the database. If notmuch was subsequently interrupted before fully populating this document, then later runs would be quite confused when seeing the partial documents. There are reports from the wild of people hitting internal errors of the form "Message ... has no thread ID" for example, (which is currently an unrecoverable error). We fix this by manually allocating document IDs without adding documents. With this change, we never call Xapian's add_document method, but only replace_document with either the current document ID of a message or a new one that we have allocated.
68 lines
2.1 KiB
C
68 lines
2.1 KiB
C
/* database-private.h - For peeking into the internals of notmuch_database_t
|
|
*
|
|
* Copyright © 2009 Carl Worth
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see http://www.gnu.org/licenses/ .
|
|
*
|
|
* Author: Carl Worth <cworth@cworth.org>
|
|
*/
|
|
|
|
#ifndef NOTMUCH_DATABASE_PRIVATE_H
|
|
#define NOTMUCH_DATABASE_PRIVATE_H
|
|
|
|
/* According to WG14/N1124, a C++ implementation won't provide us a
|
|
* macro like PRIx64 (which gives a printf format string for
|
|
* formatting a uint64_t as hexadecimal) unless we define
|
|
* __STDC_FORMAT_MACROS before including inttypes.h. That's annoying,
|
|
* but there it is.
|
|
*/
|
|
#define __STDC_FORMAT_MACROS
|
|
#include <inttypes.h>
|
|
|
|
#include "notmuch-private.h"
|
|
|
|
#include <xapian.h>
|
|
|
|
struct _notmuch_database {
|
|
notmuch_bool_t exception_reported;
|
|
|
|
char *path;
|
|
|
|
notmuch_bool_t needs_upgrade;
|
|
notmuch_database_mode_t mode;
|
|
Xapian::Database *xapian_db;
|
|
|
|
unsigned int last_doc_id;
|
|
uint64_t last_thread_id;
|
|
|
|
Xapian::QueryParser *query_parser;
|
|
Xapian::TermGenerator *term_gen;
|
|
Xapian::ValueRangeProcessor *value_range_processor;
|
|
|
|
};
|
|
|
|
/* Convert tags from Xapian internal format to notmuch format.
|
|
*
|
|
* The function gets a TermIterator as argument and uses that iterator to find
|
|
* all tag terms in the object. The tags are then converted to a
|
|
* notmuch_tags_t list and returned. The function needs to allocate memory for
|
|
* the resulting list and it uses the argument ctx as talloc context.
|
|
*
|
|
* The function returns NULL on failure.
|
|
*/
|
|
notmuch_tags_t *
|
|
_notmuch_convert_tags (void *ctx, Xapian::TermIterator &i,
|
|
Xapian::TermIterator &end);
|
|
|
|
#endif
|