mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-12-29 12:51:43 +01:00
971cdc72cd
We largely use the corpus under test/corpus for testing. Unfortunately, many of our tests have grown to depend on having exactly this set of messages, making it hard to add new message files for testing specific cases. We do use a lot of add_message from within the tests, but it's not possible to use that for adding broken messages, and adding several messages at once can get unwieldy. Move the basic corpus under tests/corpora/default, and make it possible to add new, independent corpora along its side. This means tons of renames with a few tweaks to add_email_corpus function in test-lib.sh to let tests specify which corpus to use.
31 lines
1.3 KiB
Text
31 lines
1.3 KiB
Text
From: "Carl Worth" <cworth@cworth.org>
|
|
To: notmuch@notmuchmail.org
|
|
Date: Wed, 18 Nov 2009 01:42:02 -0800
|
|
Subject: [notmuch] [PATCH 1/2] Close message file after parsing message
|
|
headers
|
|
In-Reply-To: <yunbpj0etua.fsf@aiko.keithp.com>
|
|
References: <1258471718-6781-1-git-send-email-dottedmag@dottedmag.net>
|
|
<87lji5cbwo.fsf@yoom.home.cworth.org> <yunbpj0etua.fsf@aiko.keithp.com>
|
|
Message-ID: <87pr7gqidx.fsf@yoom.home.cworth.org>
|
|
|
|
On Tue, 17 Nov 2009 13:15:25 -0800, Keith Packard <keithp at keithp.com> wrote:
|
|
> Threading the message also involves displaying the from and to contents,
|
|
> which requires opening the message file. The alternative to the fix I
|
|
> provided is to just parse all of the message headers when first opening
|
|
> the message; it could then be immediately closed and the hash referred
|
|
> to for all header data. Given the choice, just having the caller say
|
|
> when it has finished with a message is probably a reasonable option...
|
|
|
|
Hi Keith,
|
|
|
|
Once I finally got back on the ground again, I pushed out a revised
|
|
version of your patch, (didn't need the reply-to stuff anymore since I
|
|
had fixed that differently in the meantime).
|
|
|
|
I'm pretty happy with the state of this portion of the code now.
|
|
|
|
Thanks Keith and Mikhail for your input on and code to fix this bug.
|
|
|
|
-Carl
|
|
|
|
|