mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-12-22 17:34:54 +01:00
7b78eb4af6
Scott Henson reported an internal error that occurred when he tried to add a message that referenced another message with a message ID well over 300 characters in length. The bug here was running into a Xapian limit for the length of metadata key names, (which is even more restrictive than the Xapian limit for the length of terms). We fix this by noticing long message ID values and instead using a message ID of the form "notmuch-sha1-<sha1_sum_of_message_id>". That is, we use SHA1 to generate a compressed, (but still unique), version of the message ID. We add support to the test suite to exercise this fix. The tests add a message referencing the long message ID, then add the message with the long message ID, then finally add another message referencing the long ID. Each of these tests exercise different code paths where the special handling is implemented. A final test ensures that all three messages are stitched together into a single thread---guaranteeing that the three code paths all act consistently. |
||
|---|---|---|
| .. | ||
| database-private.h | ||
| database.cc | ||
| directory.cc | ||
| index.cc | ||
| libsha1.c | ||
| libsha1.h | ||
| Makefile | ||
| Makefile.local | ||
| message-file.c | ||
| message.cc | ||
| messages.c | ||
| notmuch-private.h | ||
| notmuch.h | ||
| query.cc | ||
| sha1.c | ||
| tags.c | ||
| thread.cc | ||
| xutil.c | ||
| xutil.h | ||