mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-12-22 17:34:54 +01:00
cec601c4dd
In Xapian, closing a database implicitly aborts any outstanding transaction and commits changes. For historical reasons, notmuch_database_close had grown to almost, but not quite duplicate this behavior. Before closing the database, it would explicitly (and unnecessarily) commit it. However, if there was an outstanding transaction (ie atomic section), commit would throw a Xapian exception, which notmuch_database_close would unnecessarily print to stderr, even though notmuch_database_close would ultimately abort the transaction anyway when it called close. This patch simplifies notmuch_database_close to explicitly abort any outstanding transaction and then just call Database::close. This works for both read-only and read/write databases, takes care of committing changes, unifies the exception handling path, and codifies aborting outstanding transactions. This is currently the only way to abort an atomic section (and may remain so, since it would be difficult to roll back things we may have cached from rolled-back modifications). |
||
|---|---|---|
| .. | ||
| database-private.h | ||
| database.cc | ||
| directory.cc | ||
| filenames.c | ||
| gen-version-script.sh | ||
| index.cc | ||
| libsha1.c | ||
| libsha1.h | ||
| Makefile | ||
| Makefile.local | ||
| message-file.c | ||
| message.cc | ||
| messages.c | ||
| notmuch-private.h | ||
| notmuch.h | ||
| parse-time-vrp.cc | ||
| parse-time-vrp.h | ||
| query.cc | ||
| sha1.c | ||
| string-list.c | ||
| tags.c | ||
| thread.cc | ||