notmuch/lib/string-map.c
David Bremner 4f82acce17 lib/string_map: simulate stable sorting
qsort(3) does not promise stability, and recent versions of glibc have
been showing more unstable behaviour [2]. Michael Gruber observed [1] test
breakage due to changing output order for message properties.

We provide a sorting order of (key,value) pairs that _looks_ stable by
breaking ties based on value if keys are equal. Internally there may
be some instability in the case of duplicate (key,value) pairs, but it
should not be observable via the iterator API.

[1]: id:CAA19uiSHjVFmwH0pMC7WwDYCOSzu3yqNbuYhu3ZMeNNRh313eA@mail.gmail.com
[2]: id:87msv3i44u.fsf@oldenburg.str.redhat.com
2023-11-28 09:19:21 -04:00

250 lines
5.6 KiB
C

/* string-map.c - associative arrays of strings
*
*
* Copyright © 2016 David Bremner
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see https://www.gnu.org/licenses/ .
*
* Author: David Bremner <david@tethera.net>
*/
#include "notmuch-private.h"
/* Create a new notmuch_string_map_t object, with 'ctx' as its
* talloc owner.
*
* This function can return NULL in case of out-of-memory.
*/
typedef struct _notmuch_string_pair_t {
char *key;
char *value;
} notmuch_string_pair_t;
struct _notmuch_string_map {
bool sorted;
size_t length;
notmuch_string_pair_t *pairs;
};
struct _notmuch_string_map_iterator {
notmuch_string_pair_t *current;
bool exact;
const char *key;
};
notmuch_string_map_t *
_notmuch_string_map_create (const void *ctx)
{
notmuch_string_map_t *map;
map = talloc (ctx, notmuch_string_map_t);
if (unlikely (map == NULL))
return NULL;
map->length = 0;
map->pairs = NULL;
map->sorted = true;
return map;
}
void
_notmuch_string_map_append (notmuch_string_map_t *map,
const char *key,
const char *value)
{
map->length++;
map->sorted = false;
if (map->pairs)
map->pairs = talloc_realloc (map, map->pairs, notmuch_string_pair_t, map->length + 1);
else
map->pairs = talloc_array (map, notmuch_string_pair_t, map->length + 1);
map->pairs[map->length - 1].key = talloc_strdup (map, key);
map->pairs[map->length - 1].value = talloc_strdup (map, value);
/* Add sentinel */
map->pairs[map->length].key = NULL;
map->pairs[map->length].value = NULL;
}
static int
cmppair (const void *pa, const void *pb)
{
int cmp = 0;
notmuch_string_pair_t *a = (notmuch_string_pair_t *) pa;
notmuch_string_pair_t *b = (notmuch_string_pair_t *) pb;
cmp = strcmp (a->key, b->key);
if (cmp == 0)
cmp = strcmp (a->value, b->value);
return cmp;
}
static void
_notmuch_string_map_sort (notmuch_string_map_t *map)
{
if (map->length == 0)
return;
if (map->sorted)
return;
qsort (map->pairs, map->length, sizeof (notmuch_string_pair_t), cmppair);
map->sorted = true;
}
static int
string_cmp (const char *a, const char *b, bool exact)
{
if (exact)
return (strcmp (a, b));
else
return (strncmp (a, b, strlen (a)));
}
static notmuch_string_pair_t *
bsearch_first (notmuch_string_pair_t *array, size_t len, const char *key, bool exact)
{
size_t first = 0;
size_t last = len - 1;
size_t mid;
if (len <= 0)
return NULL;
while (last > first) {
mid = (first + last) / 2;
int sign = string_cmp (key, array[mid].key, exact);
if (sign <= 0)
last = mid;
else
first = mid + 1;
}
if (string_cmp (key, array[first].key, exact) == 0)
return array + first;
else
return NULL;
}
void
_notmuch_string_map_set (notmuch_string_map_t *map,
const char *key,
const char *val)
{
notmuch_string_pair_t *pair;
/* this means that calling string_map_set invalidates iterators */
_notmuch_string_map_sort (map);
pair = bsearch_first (map->pairs, map->length, key, true);
if (! pair)
_notmuch_string_map_append (map, key, val);
else {
talloc_free (pair->value);
pair->value = talloc_strdup (map->pairs, val);
}
}
const char *
_notmuch_string_map_get (notmuch_string_map_t *map, const char *key)
{
notmuch_string_pair_t *pair;
/* this means that calling append invalidates iterators */
_notmuch_string_map_sort (map);
pair = bsearch_first (map->pairs, map->length, key, true);
if (! pair)
return NULL;
return pair->value;
}
notmuch_string_map_iterator_t *
_notmuch_string_map_iterator_create (notmuch_string_map_t *map, const char *key,
bool exact)
{
notmuch_string_map_iterator_t *iter;
_notmuch_string_map_sort (map);
iter = talloc (map, notmuch_string_map_iterator_t);
if (unlikely (iter == NULL))
return NULL;
if (unlikely (talloc_reference (iter, map) == NULL))
return NULL;
iter->key = talloc_strdup (iter, key);
iter->exact = exact;
iter->current = bsearch_first (map->pairs, map->length, key, exact);
return iter;
}
bool
_notmuch_string_map_iterator_valid (notmuch_string_map_iterator_t *iterator)
{
if (iterator->current == NULL)
return false;
/* sentinel */
if (iterator->current->key == NULL)
return false;
return (0 == string_cmp (iterator->key, iterator->current->key, iterator->exact));
}
void
_notmuch_string_map_iterator_move_to_next (notmuch_string_map_iterator_t *iterator)
{
if (! _notmuch_string_map_iterator_valid (iterator))
return;
(iterator->current)++;
}
const char *
_notmuch_string_map_iterator_key (notmuch_string_map_iterator_t *iterator)
{
if (! _notmuch_string_map_iterator_valid (iterator))
return NULL;
return iterator->current->key;
}
const char *
_notmuch_string_map_iterator_value (notmuch_string_map_iterator_t *iterator)
{
if (! _notmuch_string_map_iterator_valid (iterator))
return NULL;
return iterator->current->value;
}
void
_notmuch_string_map_iterator_destroy (notmuch_string_map_iterator_t *iterator)
{
talloc_free (iterator);
}